* [PATCH] drivers/base/class.c: fix swapped memset() arguments
@ 2005-09-12 13:58 Alexey Dobriyan
2005-09-12 18:23 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2005-09-12 13:58 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
drivers/base/class.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-vanilla/drivers/base/class.c
+++ linux-memset/drivers/base/class.c
@@ -506,7 +506,7 @@ int class_device_add(struct class_device
kobject_del(&class_dev->kobj);
goto register_done;
}
- memset(attr, sizeof(*attr), 0x00);
+ memset(attr, 0x00, sizeof(*attr));
attr->attr.name = "dev";
attr->attr.mode = S_IRUGO;
attr->attr.owner = parent->owner;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/base/class.c: fix swapped memset() arguments
2005-09-12 13:58 [PATCH] drivers/base/class.c: fix swapped memset() arguments Alexey Dobriyan
@ 2005-09-12 18:23 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2005-09-12 18:23 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Greg Kroah-Hartman, linux-kernel
Alexey Dobriyan napsal(a):
>Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>---
>
> drivers/base/class.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
>--- linux-vanilla/drivers/base/class.c
>+++ linux-memset/drivers/base/class.c
>@@ -506,7 +506,7 @@ int class_device_add(struct class_device
> kobject_del(&class_dev->kobj);
> goto register_done;
> }
>- memset(attr, sizeof(*attr), 0x00);
>+ memset(attr, 0x00, sizeof(*attr));
> attr->attr.name = "dev";
> attr->attr.mode = S_IRUGO;
> attr->attr.owner = parent->owner;
>
>
Consider use of kzalloc, some of latest git snapshot contains it yet.
Maybe you want to replace all occurences of memset in this source with
that as I took a look.
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ jirislaby@gmail.com ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-09-12 18:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-12 13:58 [PATCH] drivers/base/class.c: fix swapped memset() arguments Alexey Dobriyan
2005-09-12 18:23 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox