Re: [PATCH 2.6.13 5/14] sas-class: sas_discover.c Discover process (end devices)

Nish Aravamudan
2005-09-09T19:59:16Z

On 9/9/05, Luben Tuikov <luben_tuikov@adaptec.com> wrote:
> Signed-off-by: Luben Tuikov <luben_tuikov@adaptec.com>

<snip>

+static int sas_execute_task(struct sas_task *task, void *buffer, int size,
+ int pci_dma_dir)

<snip>

+ set_current_state(TASK_INTERRUPTIBLE);
+ schedule_timeout(HZ);

<snip>

+ set_current_state(TASK_INTERRUPTIBLE);
+ schedule_timeout(5*HZ);

Can you use msleep_interruptible() here? I don't see wait-queues in
the immediate vicinity. If not, and you're going for the normal -mm
route (and from there to mainline), can you use
schedule_timeout_interruptible(), please?

Thanks,
Nish