From: Markus Lidel <Markus.Lidel@shadowconnect.com>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] Couple of I2O sysfs changes
Date: Tue, 13 Sep 2005 12:33:28 +0200 [thread overview]
Message-ID: <4326AAF8.2060702@shadowconnect.com> (raw)
In-Reply-To: <200509122331.59554.dtor_core@ameritech.net>
Hello,
Dmitry Torokhov wrote:
> I was looking at the users of class_interfaces and stumbled across
> I2O subsystem. As far as I understand the purpose of class interfaces
> was to provide different 'views' on the hardware, not just to have
> a callback to finish initialization of sysfs structures. I think it
> woudl be better to remove i2o_device_class_interface and create
> user/parent links right after class device registration.
OK, think i've misunderstood the description of the class interface :-(
> Also, it looks like i2o_device_class itself is not needed - correct
> me if I am wrong, but all i2o devics reside on their own bus so
> i2o_devices class simply mirrors iformation from the bus and can
> also be safely removed.
Nope, there is one bus per controller not per device...
> Please consider applying the 2 pathes below (just compile-tested,
> don't have proper hardware).
I'll try to merge the changes (and some other patches) in the near future
and provide a changed patch...
Thank you very much.
Best regards,
Markus Lidel
------------------------------------------
Markus Lidel (Senior IT Consultant)
Shadow Connect GmbH
Carl-Reisch-Weg 12
D-86381 Krumbach
Germany
Phone: +49 82 82/99 51-0
Fax: +49 82 82/99 51-11
E-Mail: Markus.Lidel@shadowconnect.com
URL: http://www.shadowconnect.com
next prev parent reply other threads:[~2005-09-13 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-13 4:31 [PATCH 0/2] Couple of I2O sysfs changes Dmitry Torokhov
2005-09-13 4:34 ` [PATCH 1/2] I2O: remove i2o_device_class_interface Dmitry Torokhov
2005-09-13 4:34 ` [PATCH 1/2] I2O: remove i2o_device_class Dmitry Torokhov
2005-09-13 10:33 ` Markus Lidel [this message]
2005-09-13 19:06 ` [PATCH 0/2] Couple of I2O sysfs changes Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4326AAF8.2060702@shadowconnect.com \
--to=markus.lidel@shadowconnect.com \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox