From: Mike Christie <michaelc@cs.wisc.edu>
To: Timothy Thelin <Timothy.Thelin@wdc.com>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2.6.13] scsi: sd fails to copy cmd_len on SG_IO
Date: Tue, 13 Sep 2005 12:48:43 -0500 [thread overview]
Message-ID: <432710FB.1000802@cs.wisc.edu> (raw)
In-Reply-To: <CA45571DE57E1C45BF3552118BA92C9D69BDD8@WDSCEXBECL03.sc.wdc.com>
Timothy Thelin wrote:
> This fixes an issue when doing SG_IO on an sd device: the
> sd driver fails to copy the request's cmd_len to the scsi
> command's cmd_len when initializing the command.
>
Do you need the same fix to st, sr, and scsi_lib (in the
scsi_generic_done path)?
> Signed-off-by: Timothy Thelin <timothy.thelin@wdc.com>
>
> --- linux-2.6.13.orig/drivers/scsi/sd.c 2005-08-28 16:41:01.000000000 -0700
> +++ linux-2.6.13/drivers/scsi/sd.c 2005-09-13 09:39:06.000000000 -0700
> @@ -236,6 +236,7 @@ static int sd_init_command(struct scsi_c
> return 0;
>
> memcpy(SCpnt->cmnd, rq->cmd, sizeof(SCpnt->cmnd));
> + SCpnt->cmd_len = rq->cmd_len;
> if (rq_data_dir(rq) == WRITE)
> SCpnt->sc_data_direction = DMA_TO_DEVICE;
> else if (rq->data_len)
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2005-09-13 17:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-13 17:39 [PATCH 2.6.13] scsi: sd fails to copy cmd_len on SG_IO Timothy Thelin
2005-09-13 17:48 ` Mike Christie [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-09-13 18:26 Timothy Thelin
2005-09-13 19:05 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=432710FB.1000802@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@SteelEye.com \
--cc=Timothy.Thelin@wdc.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox