From: Jeff Garzik <jgarzik@pobox.com>
To: mike.miller@hp.com
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Jens Axboe <axboe@suse.de>
Subject: Re: [PATCH] cciss: bug fix in cciss_remove_one
Date: Tue, 13 Sep 2005 15:27:02 -0400 [thread overview]
Message-ID: <43272806.60806@pobox.com> (raw)
In-Reply-To: <200509131910.j8DJAOfZ024676@hera.kernel.org>
Linux Kernel Mailing List wrote:
> tree 30a07d018d74fbd99d323d6d6a6e08cac3a1b767
> parent 33079b21978f478865068ee6a3c5807b6c6ecdbe
> author Mike Miller <mike.miller@hp.com> Tue, 13 Sep 2005 15:25:23 -0700
> committer Linus Torvalds <torvalds@g5.osdl.org> Tue, 13 Sep 2005 22:22:30 -0700
>
> [PATCH] cciss: bug fix in cciss_remove_one
>
> This patch fixes a bug in cciss_remove_one. A set of braces was missing for
> the if statement causing an Oops on driver unload.
>
> Signed-off-by: Mike Miller <mike.miller@hp.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
>
> drivers/block/cciss.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -3095,9 +3095,10 @@ static void __devexit cciss_remove_one (
> /* remove it from the disk list */
> for (j = 0; j < NWD; j++) {
> struct gendisk *disk = hba[i]->gendisk[j];
> - if (disk->flags & GENHD_FL_UP)
> - blk_cleanup_queue(disk->queue);
> + if (disk->flags & GENHD_FL_UP) {
> del_gendisk(disk);
> + blk_cleanup_queue(disk->queue);
hrm. Would be nice to get cciss patches reviewed by Jens or me, or
somebody...
Take a look at drivers/block/sx8.c:carm_free_disks() for the proper way
to do this.
Jeff
parent reply other threads:[~2005-09-13 19:27 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200509131910.j8DJAOfZ024676@hera.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43272806.60806@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.miller@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox