From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754491AbcAHIs3 (ORCPT ); Fri, 8 Jan 2016 03:48:29 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:58169 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751612AbcAHIs1 (ORCPT ); Fri, 8 Jan 2016 03:48:27 -0500 From: Arnd Bergmann To: Greg Hackmann Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Jonathan Corbet , Anton Vorontsov , Colin Cross , Kees Cook , Tony Luck , John Stultz , linux-doc@vger.kernel.org Subject: Re: [PATCH v3] pstore-ram: add Device Tree bindings Date: Fri, 08 Jan 2016 09:48 +0100 Message-ID: <4327736.BAId4lHCG7@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1452210056-14436-1-git-send-email-ghackmann@google.com> References: <1452210056-14436-1-git-send-email-ghackmann@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:kRDq7cQTY7ZOat8xBGsyB098INwxx13OZKXOhQ6hvK8qDwsFRB+ 9tLih3lLjyq1jjSGZYsLpgDMVk+mRIXaF7XrWncX/PmkFSLjg/EE/uLj3wze5m+67qbFJJY B2jYdOmhkQoYTwKOA7959sMReUJKzKtuOmoWYuy3OokyXUA+QLywqL9AeyiorTYUMmcn74l Cn2WmnGUpVkJxlEdUZ00g== X-UI-Out-Filterresults: notjunk:1;V01:K0:9W2k5nDKosE=:BMcKTd2rYbJlUgy6n4TA84 ZdNC7GkOpOfXrQHx4o9wgmOe2IIGvJD+hCwOTIKzqyW6zc84QQfnvHTZNI/Hd5BXR/UlyfO+A FjxFYApxC2dMxRYeJuRrkQlqAsUxYQ+fvjJLyRIR+TJ7cLm4E8lQ50LtrN2d2Bfv4p6qjL8/j zlwn0sF9Mkh0oGW3aMnLnFe1g2czds+Cjm73AYlnG/SAEZJqzh3SvtkwnY+LDa50uocG9nq8S ixOoxfpwFKxJS4mkhb+vyrKgWV3hOyNwhwmlhRovoS6HrY4ib1Z96FoDgaY2TKh5gqwWqViix hAaqJH4tFzPcFEylmI8hPJHd6nhazX53dZqLkzRxGwCbEn0I1m4tvSLNtl3cNHYAp0dMekwiF OwvtHGMPo83XLRGYfM1HzQgqCw5T48H9mpfi/AKF4jFPgSmONXlDyur2V/OUxJJ/SOdlmu3TE mWM6zPG6uCj+/U0qY3YYcPJnDpVH96gxRqVq4GjcKcxk0WsA/Ru9QlpXjyYkDHD8V+ERxFksS IsopsvEOdIQd9jsjBdgP7Oh1/gJaADwTmaEtPYZV1BKZ1hy3tZWqG1zMsrbYshjzBkiPyxVj1 cIHMrLF3I2Js3jHMOoNzmVN3MT891eHWkaa4A6K8PRqtXkm1kLnSWX1US06hyUQFX6x6HcQNA wp6b+VZOPBtIKQGpzc82U8XNyx/dUD0vCFw1nzMqET5jJCnaRP8h0NUA/IfAA0ZYpCkQvQTbY KfoaTo+yrqyFeBpC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 07 January 2016 15:40:56 Greg Hackmann wrote: > ramoops is one of the remaining places where ARM vendors still rely on > board-specific shims. Device Tree lets us replace those shims with > generic code. > > These bindings mirror the ramoops module parameters, with two small > differences: > > (1) dump_oops becomes an optional "no-dump-oops" property, since ramoops > sets dump_oops=1 by default. > > (2) mem_type=1 becomes the more self-explanatory "unbuffered" property. > > Signed-off-by: Greg Hackmann > --- > Changes in V3: > - documentation fixes > - look for "no-ram-oops" property as documented > > Changes in V2: > - make DT binding documentation more generic > > Documentation/devicetree/bindings/misc/ramoops.txt | 43 ++++++++ > Documentation/ramoops.txt | 6 +- > fs/pstore/ram.c | 110 ++++++++++++++++++++- > 3 files changed, 155 insertions(+), 4 deletions(-) > create mode 100644 Documentation/devicetree/bindings/misc/ramoops.txt > > diff --git a/Documentation/devicetree/bindings/misc/ramoops.txt b/Documentation/devicetree/bindings/misc/ramoops.txt > new file mode 100644 > index 0000000..5a475fa > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/ramoops.txt > @@ -0,0 +1,43 @@ > +Ramoops oops/panic logger > +========================= > + > +ramoops provides persistent RAM storage for oops and panics, so they can be > +recovered after a reboot. > + > +Parts of this storage may be set aside for other persistent log buffers, such > +as kernel log messages, or for optional ECC error-correction data. The total > +size of these optional buffers must fit in the reserved region. > + > +Any remaining space will be used for a circular buffer of oops and panic > +records. These records have a configurable size, with a size of 0 indicating > +that they should be disabled. > + > + > +Required properties: > + > +- compatible: must be "ramoops" > + > +- memory-region: phandle to a region of memory that is preserved between reboots > + I still think putting it into the pstore node would be better here. Arnd