From: Stefan Smietanowski <stesmi@stesmi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Harald Welte <laforge@gnumonks.org>,
linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH 2/2] New Omnikey Cardman 4000 driver
Date: Wed, 14 Sep 2005 13:20:51 +0200 [thread overview]
Message-ID: <43280793.8070809@stesmi.com> (raw)
In-Reply-To: <20050914022314.35eab48d.akpm@osdl.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andrew Morton wrote:
> Harald Welte <laforge@gnumonks.org> wrote:
>
>>Add new Omnikey Cardman 4000 smartcard reader driver
>
>
> - All the open-coded mdelays() are wrong:
>
> #define T_10MSEC msecs_to_jiffies(10)
> ...
> mdelay(T_10MSEC);
>
> mdelay() already takes a jiffies argument.
And isn't that what he's doing?
He wants 10ms. Converts to jiffies (msec_to_jiffies())
and passes it to mdelay().
mdelay(T_10MSEC);
mdelay(msecs_to_jiffies(10));
// Stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (MingW32)
iD8DBQFDKAeTBrn2kJu9P78RAh9AAKCuNe3gGCYfi3yEVLglF4Wr1+1CtQCgus3n
ePboO9jbsSSaDkLrG00kvbM=
=k/B4
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2005-09-14 11:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-13 15:53 [PATCH 2/2] New Omnikey Cardman 4000 driver Harald Welte
2005-09-14 9:23 ` Andrew Morton
2005-09-14 11:20 ` Stefan Smietanowski [this message]
2005-09-14 11:42 ` Arjan van de Ven
2005-09-18 21:22 ` [PATCH] Omnikey CardMan 4000 update Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43280793.8070809@stesmi.com \
--to=stesmi@stesmi.com \
--cc=akpm@osdl.org \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox