From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65EB3C433E1 for ; Fri, 12 Jun 2020 16:27:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34445207ED for ; Fri, 12 Jun 2020 16:27:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="nRvp5ktR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726283AbgFLQ1y (ORCPT ); Fri, 12 Jun 2020 12:27:54 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:44424 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726085AbgFLQ1x (ORCPT ); Fri, 12 Jun 2020 12:27:53 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 05CGRAm3015312; Fri, 12 Jun 2020 11:27:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1591979230; bh=Fkgey716kLKI5iJmQP/27R3X8I0hgKSTact+Z6ZhrrA=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=nRvp5ktRa3UD52SFpinmzJWjGxRQgF6w36M+Y5QezRyrFu+O77uOkdTRy5rYRC/9T 2HAjkKHhYeD82VhVoUaw0508z3QU8ZX8aATV+IiDjNm0gUjY5LPcdFuseNoUtICQjV J8WiQ/nQSDELSHTB4ouX2r/5ye2r0+hoM8Y/Czk0= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 05CGRAOA025356; Fri, 12 Jun 2020 11:27:10 -0500 Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 12 Jun 2020 11:27:09 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 12 Jun 2020 11:27:09 -0500 Received: from [10.250.52.63] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 05CGR9nZ003371; Fri, 12 Jun 2020 11:27:09 -0500 Subject: Re: [PATCH v3 2/2] ASoC: tas2562: Update shutdown GPIO property To: Mark Brown CC: , , , , , , References: <20200612160603.2456-1-dmurphy@ti.com> <20200612160603.2456-2-dmurphy@ti.com> <20200612160922.GL5396@sirena.org.uk> <0e482167-71c2-a128-b8b4-a054557d30e9@ti.com> <20200612162200.GM5396@sirena.org.uk> From: Dan Murphy Message-ID: <432c41fe-8afa-2ccb-8917-fd64f4895144@ti.com> Date: Fri, 12 Jun 2020 11:27:04 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200612162200.GM5396@sirena.org.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark On 6/12/20 11:22 AM, Mark Brown wrote: > On Fri, Jun 12, 2020 at 11:18:57AM -0500, Dan Murphy wrote: >> On 6/12/20 11:09 AM, Mark Brown wrote: >>> On Fri, Jun 12, 2020 at 11:06:03AM -0500, Dan Murphy wrote: >>>> - tas2562->sdz_gpio = devm_gpiod_get_optional(dev, "shut-down-gpio", >>>> + tas2562->sdz_gpio = devm_gpiod_get_optional(dev, "shutdown", >>>> GPIOD_OUT_HIGH); >>> This also changes the name from shut-down to shutdown which will be >>> incompatible (IIRC we do try -gpio as well as -gpios). >> Yes the non-standardish name was highlighted by Rob[1]. > Yes, but we released with it so it's an ABI now and we should still > support the old name. Well should we then just revert back to the non-standard name and just fix up the code? Or should we support both properties? Dan