Re: p = kmalloc(sizeof(*p), )

Jeff Garzik
2005-09-20T18:42:17Z

Russell King wrote:
> On Tue, Sep 20, 2005 at 10:59:39AM -0700, Andrew Morton wrote:
>
>>>"I want to grep for
>>>initialisations" is pretty pointless because a) it won't catch everything
>>>anyway and b) most structures are allocated and initialised at a single
>>>place and many of those which aren't should probably be converted to do
>>>that anyway.
>>>
>>>The broader point is that you're trying to optimise for the wrong thing.
>>>We should optimise for those who read code, not for those who write it.
>>>
>>
>>If you look back, your five reasons tend to address modifiability, not
>>readability.
>
>
> So what you're saying is that we should optimise the code so that
> we make mistakes when we modify it. Umm, yes, of course.
>
> This is a contentious issue, and I don't think anyone should be
> stipulating which way is the right way - which is exactly what
> has been done by placing it in Coding Style. Remember, we have
> kernel janitors who _will_ change code to match that.

Precisely. Since there is enough disagreement, it lacks consensus to be
in CodingStyle.

Jeff