From: Krzysztof Kozlowski <krzk@kernel.org>
To: dongxuyang@eswincomputing.com, p.zabel@pengutronix.de,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com,
huangyifeng@eswincomputing.com
Subject: Re: [PATCH 1/2] dt-bindings: reset: eswin: Documentation for eic7700 SoC
Date: Fri, 16 May 2025 15:27:26 +0200 [thread overview]
Message-ID: <43341d97-e6fc-4b09-82cf-ea81d9f877bb@kernel.org> (raw)
In-Reply-To: <20250514003121.473-1-dongxuyang@eswincomputing.com>
On 14/05/2025 02:31, dongxuyang@eswincomputing.com wrote:
> diff --git a/include/dt-bindings/reset/eswin,eic7700-reset.h b/include/dt-bindings/reset/eswin,eic7700-reset.h
> new file mode 100644
> index 000000000000..fcf004620db9
> --- /dev/null
> +++ b/include/dt-bindings/reset/eswin,eic7700-reset.h
> @@ -0,0 +1,460 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright 2024, Beijing ESWIN Computing Technology Co., Ltd.. All rights reserved.
> + *
> + * Device Tree binding constants for EIC7700 reset controller.
> + *
> + * Authors:
> + * Yifeng Huang <huangyifeng@eswincomputing.com>
> + * Xuyang Dong <dongxuyang@eswincomputing.com>
> + */
> +
> +#ifndef __DT_ESWIN_EIC7700_RESET_H__
> +#define __DT_ESWIN_EIC7700_RESET_H__
> +
> +#define SNOC_RST_CTRL 0X00
No, IDs are abstract, decimal numbers going from 0. Not hex.
...
> +#define SW_NOC_NSP_RSTN (1 << 0)
All these are not really bindings IDs either. This all should be 0, 1, 2
etc. Do not treat hardware numbers as bindings, because it is not needed
and it does not bring any benefits.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-16 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 0:29 [PATCH 0/2] Add driver support for ESWIN eic7700 SoC reset controller dongxuyang
2025-05-14 0:31 ` [PATCH 1/2] dt-bindings: reset: eswin: Documentation for eic7700 SoC dongxuyang
2025-05-14 1:35 ` Rob Herring (Arm)
2025-05-14 13:30 ` Rob Herring
2025-05-16 13:27 ` Krzysztof Kozlowski [this message]
2025-05-14 0:32 ` [PATCH 2/2] reset: eswin: Add eic7700 reset driver dongxuyang
2025-05-16 13:25 ` Krzysztof Kozlowski
2025-05-16 15:48 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43341d97-e6fc-4b09-82cf-ea81d9f877bb@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongxuyang@eswincomputing.com \
--cc=huangyifeng@eswincomputing.com \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox