The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mremap move ZERO_PAGE fix
Date: Sun, 25 Sep 2005 11:21:32 +1000	[thread overview]
Message-ID: <4335FB9C.50602@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.61.0509241127420.11579@goblin.wat.veritas.com>

Hugh Dickins wrote:
> Fix nasty little bug we've missed in Nick's mremap move ZERO_PAGE patch.
> The "pte" at that point may be a swap entry or a pte_file entry: we must
> check pte_present before perhaps corrupting such an entry.
> 
> Patch below against 2.6.14-rc2-mm1, but the same bug is in 2.6.14-rc2's
> mm/mremap.c, and more dangerous there since it's affecting all arches:
> I think the safest course is to send Nick's patch and Yoichi's build fix
> and this fix (build tested) on to Linus - so only MIPS can be affected.
> 

Thanks Hugh. I agree with your proposed merge plan.

-- 
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com 

      reply	other threads:[~2005-09-25  1:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-24 10:30 [PATCH] mremap move ZERO_PAGE fix Hugh Dickins
2005-09-25  1:21 ` Nick Piggin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4335FB9C.50602@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@osdl.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox