From: Jay Lan <jlan@engr.sgi.com>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: Hugh Dickins <hugh@veritas.com>,
Frank van Maarseveen <frankvm@frankvm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.14-rc2] fix incorrect mm->hiwater_vm and mm->hiwater_rss
Date: Tue, 27 Sep 2005 15:43:33 -0700 [thread overview]
Message-ID: <4339CB15.9060602@engr.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0509271449280.10674@schroedinger.engr.sgi.com>
Christoph Lameter wrote:
> On Tue, 27 Sep 2005, Jay Lan wrote:
>
>
>>Just looked at the __vm_stat_account() code. It is enclosed inside
>>#ifdef CONFIG_PROC_FS.
>>
>>If that is necessary, i can not put hiwater_vm update code in there. The
>>system accounting code should not be dependent on a config flag that has
>>nothing to do with system accounting.
>
>
> I doubt you can do accounting without having /proc. Dont you need to
> read/write files in /proc? Can we make accounting dependent on /proc?
Right, system accounting code (BSD_PROCESS_ACCT) does not depend on
/proc.
In my opinion, those "everyone should say Y here" config flags should
not be config flags at all. Since it is a flag, i should not put
sys accounting code in there.
next prev parent reply other threads:[~2005-09-27 22:43 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-21 12:19 [PATCH 2.6.14-rc2] fix incorrect mm->hiwater_vm and mm->hiwater_rss Frank van Maarseveen
2005-09-21 14:38 ` Hugh Dickins
2005-09-21 14:58 ` Frank van Maarseveen
2005-09-21 15:35 ` Hugh Dickins
2005-09-21 18:42 ` Frank van Maarseveen
2005-09-21 18:57 ` Hugh Dickins
2005-09-21 15:26 ` Christoph Lameter
2005-09-21 15:50 ` Frank van Maarseveen
2005-09-21 16:57 ` Jay Lan
2005-09-21 17:05 ` Christoph Lameter
2005-09-21 17:39 ` Jay Lan
2005-09-21 18:06 ` Frank van Maarseveen
2005-09-21 18:38 ` Jay Lan
2005-09-21 17:12 ` Hugh Dickins
2005-09-21 17:31 ` Jay Lan
2005-09-21 17:45 ` Christoph Lameter
2005-09-21 17:46 ` Hugh Dickins
2005-09-21 18:05 ` Jay Lan
2005-09-21 18:26 ` Frank van Maarseveen
2005-09-21 19:19 ` Hugh Dickins
2005-09-21 19:28 ` Frank van Maarseveen
2005-09-21 19:38 ` Jay Lan
2005-09-21 19:47 ` Hugh Dickins
2005-09-21 19:48 ` Frank van Maarseveen
2005-09-21 19:52 ` Hugh Dickins
2005-09-21 19:48 ` Christoph Lameter
2005-09-21 20:06 ` Hugh Dickins
2005-09-21 20:13 ` Christoph Lameter
2005-09-27 20:43 ` Jay Lan
2005-09-27 21:47 ` Jay Lan
2005-09-27 21:50 ` Christoph Lameter
2005-09-27 22:43 ` Jay Lan [this message]
2005-09-28 13:18 ` Hugh Dickins
2005-09-28 17:31 ` Jay Lan
2005-10-03 19:53 ` Hugh Dickins
2005-10-04 8:59 ` Frank van Maarseveen
2005-10-04 21:48 ` Jay Lan
2005-10-07 2:09 ` Jay Lan
2005-10-07 3:03 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4339CB15.9060602@engr.sgi.com \
--to=jlan@engr.sgi.com \
--cc=clameter@engr.sgi.com \
--cc=frankvm@frankvm.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).