From: Petr Vandrovec <vandrove@vc.cvut.cz>
To: Ravikiran G Thirumalai <kiran@scalex86.org>
Cc: Andrew Morton <akpm@osdl.org>,
Christoph Lameter <clameter@engr.sgi.com>,
alokk@calsoftinc.com, linux-kernel@vger.kernel.org,
manfred@colorfullife.com,
"Shai Fultheim (Shai@scalex86.org)" <shai@scalex86.org>,
ananth@in.ibm.com, Andi Kleen <ak@suse.de>
Subject: Re: 2.6.14-rc1-git-now still dying in mm/slab - this time line 1849
Date: Thu, 29 Sep 2005 18:43:05 +0200 [thread overview]
Message-ID: <433C1999.2060201@vc.cvut.cz> (raw)
In-Reply-To: <20050928210245.GA3760@localhost.localdomain>
Ravikiran G Thirumalai wrote:
Unfortunately I must confirm that it does not fix problem. But it pointed
out to me another thing - proc_inode_cache stuff is put into caches
BEFORE this code is executed. So if anything in mm/slab.c relies
on node_to_mask[] being valid (and if it relies on some other things
which are set this late), it probably won't work.
Petr
> On Tue, Sep 20, 2005 at 03:58:16PM +0200, Petr Vandrovec wrote:
> Index: linux-2.6.14-rc1/arch/x86_64/mm/numa.c
> ===================================================================
> --- linux-2.6.14-rc1.orig/arch/x86_64/mm/numa.c 2005-09-19 17:58:10.000000000 -0700
> +++ linux-2.6.14-rc1/arch/x86_64/mm/numa.c 2005-09-27 01:34:20.000000000 -0700
> @@ -178,7 +178,6 @@
> rr++;
> }
>
> - set_bit(0, &node_to_cpumask[cpu_to_node(0)]);
> }
>
> #ifdef CONFIG_NUMA_EMU
> @@ -266,9 +265,7 @@
>
> __cpuinit void numa_add_cpu(int cpu)
> {
> - /* BP is initialized elsewhere */
> - if (cpu)
> - set_bit(cpu, &node_to_cpumask[cpu_to_node(cpu)]);
> + set_bit(cpu, &node_to_cpumask[cpu_to_node(cpu)]);
> }
>
> unsigned long __init numa_free_all_bootmem(void)
>
next prev parent reply other threads:[~2005-09-29 16:43 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-15 16:51 2.6.14-rc1-git-now still dying in mm/slab - this time line 1849 Petr Vandrovec
2005-09-15 17:33 ` Petr Vandrovec
[not found] ` <20050916023005.4146e499.akpm@osdl.org>
[not found] ` <432AA00D.4030706@vc.cvut.cz>
[not found] ` <20050916230809.789d6b0b.akpm@osdl.org>
2005-09-19 16:02 ` Petr Vandrovec
2005-09-19 18:29 ` Andrew Morton
2005-09-19 18:51 ` Christoph Lameter
2005-09-19 19:28 ` Andrew Morton
2005-09-19 21:20 ` Christoph Lameter
2005-09-20 5:16 ` Andrew Morton
2005-09-20 8:34 ` Alok Kataria
2005-09-20 13:58 ` Petr Vandrovec
2005-09-21 1:03 ` Christoph Lameter
2005-09-21 1:22 ` Petr Vandrovec
2005-09-21 15:59 ` Christoph Lameter
2005-09-22 19:52 ` Christoph Lameter
2005-09-22 20:01 ` Andrew Morton
2005-09-22 21:25 ` Petr Vandrovec
2005-09-22 21:32 ` Christoph Lameter
2005-09-22 21:46 ` Andrew Morton
2005-09-22 21:54 ` Christoph Lameter
2005-09-23 0:25 ` Petr Vandrovec
2005-09-28 21:02 ` Ravikiran G Thirumalai
2005-09-28 22:50 ` Christoph Lameter
2005-09-29 16:43 ` Petr Vandrovec [this message]
2005-09-29 18:11 ` Ravikiran G Thirumalai
2005-09-29 18:38 ` Christoph Lameter
2005-09-30 5:45 ` Ravikiran G Thirumalai
2005-09-30 6:05 ` Andrew Morton
2005-09-30 6:28 ` Ravikiran G Thirumalai
2005-09-30 15:16 ` Bryan O'Sullivan
2005-09-30 15:57 ` Christoph Lameter
2005-09-30 16:45 ` Bryan O'Sullivan
2005-09-30 20:11 ` Andi Kleen
2005-09-30 20:23 ` Ravikiran G Thirumalai
2005-09-30 16:55 ` Christoph Lameter
2005-09-19 18:56 ` Petr Vandrovec
2005-09-19 19:08 ` Christoph Lameter
-- strict thread matches above, loose matches on Subject: below --
2005-09-23 19:34 Alok Kataria
2005-09-23 23:57 ` Christoph Lameter
2005-09-24 0:05 ` Christoph Lameter
2005-09-24 12:52 ` Manfred Spraul
2005-09-25 14:16 Alok Kataria
2005-09-26 18:00 ` Christoph Lameter
2005-09-26 19:34 ` Alok Kataria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433C1999.2060201@vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=alokk@calsoftinc.com \
--cc=ananth@in.ibm.com \
--cc=clameter@engr.sgi.com \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=shai@scalex86.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox