From: Petr Vandrovec <vandrove@vc.cvut.cz>
To: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
Cc: Andi Kleen <ak@suse.de>, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [Patch] x86, x86_64: fix cpu model for family 0x6
Date: Sat, 01 Oct 2005 00:37:39 +0200 [thread overview]
Message-ID: <433DBE33.7090700@vc.cvut.cz> (raw)
In-Reply-To: <20050930152358.D28092@unix-os.sc.intel.com>
Siddha, Suresh B wrote:
> On Sat, Oct 01, 2005 at 12:02:16AM +0200, Andi Kleen wrote:
>
>>I applied an earlier mix of your original one and Petr's suggestions. Hope
>>it's ok.
>
>
> Andi I prefer to follow the SDM guidelines. Who knows if future families
> comeup with a different rule or use/initialize these extended model/family
> bits differently. I am just being paranoid.
And which chance is bigger - that such hypothetical processor will use
extended model, and your code will get incorrect answer everywhere, or
that such hypothetical processor will not use extended model, and your
code will be right?
>>+ if (c->x86 >= 0xf)
>
>
> And also you have a typo. It should be 0x6.
It is intentional. Maybe it could do BUG_ON(c->x86 < 0xf).
Petr
next prev parent reply other threads:[~2005-09-30 22:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-30 2:04 [Patch] x86, x86_64: fix cpu model for family 0x6 Siddha, Suresh B
2005-09-30 8:11 ` Andi Kleen
2005-09-30 13:09 ` Petr Vandrovec
2005-09-30 18:23 ` Siddha, Suresh B
2005-09-30 22:02 ` Andi Kleen
2005-09-30 22:23 ` Siddha, Suresh B
2005-09-30 22:37 ` Petr Vandrovec [this message]
2005-09-30 22:56 ` Dave Jones
2005-09-30 22:46 ` Andi Kleen
2005-10-01 1:37 ` Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433DBE33.7090700@vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox