From: David Hildenbrand <david@redhat.com>
To: Nadav Amit <nadav.amit@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
Arnd Bergmann <arnd@arndb.de>, Nadav Amit <namit@vmware.com>
Subject: Re: [PATCH 3/3] vmw_balloon: open-code vmballoon_compaction_init()
Date: Wed, 14 Sep 2022 12:14:33 +0200 [thread overview]
Message-ID: <433f00b8-c860-e2ad-09ba-b1abd4dc6189@redhat.com> (raw)
In-Reply-To: <20220913094306.317734-4-namit@vmware.com>
On 13.09.22 11:43, Nadav Amit wrote:
> From: Nadav Amit <namit@vmware.com>
>
> Following commit 68f2736a85832 ("mm: Convert all PageMovable users to
> movable_operations"), the code of vmballoon_compaction_init() is very
> simple and does not worth a separate function.
>
> Instead, open code vmballoon_compaction_init. As migratepage is always
> defined, use IS_ENABLED(), which makes the code easier to read. No
> functional change is intended.
>
> Signed-off-by: Nadav Amit <namit@vmware.com>
> ---
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-09-14 10:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 9:43 [PATCH 0/3] vmw_balloon: misc fixes and enhancements Nadav Amit
2022-09-13 9:43 ` [PATCH 1/3] vmw_balloon: access reset_required through READ/WRITE_ONCE Nadav Amit
2022-09-13 9:43 ` [PATCH 2/3] vmw_balloon: exit if initalization fails Nadav Amit
2022-09-13 9:43 ` [PATCH 3/3] vmw_balloon: open-code vmballoon_compaction_init() Nadav Amit
2022-09-14 10:14 ` David Hildenbrand [this message]
2022-09-15 0:05 ` kernel test robot
2022-09-15 3:16 ` Nadav Amit
2022-09-16 8:10 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433f00b8-c860-e2ad-09ba-b1abd4dc6189@redhat.com \
--to=david@redhat.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nadav.amit@gmail.com \
--cc=namit@vmware.com \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox