From: Vitaly Wool <vwool@ru.mvista.com>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: David Brownell <david-b@pacbell.net>,
linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net, basicmark@yahoo.com,
stephen@streetfiresound.com, dpervushin@gmail.com,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH/RFC 1/2] simple SPI framework
Date: Wed, 05 Oct 2005 13:13:47 +0400 [thread overview]
Message-ID: <4343994B.6060306@ru.mvista.com> (raw)
In-Reply-To: <20051005090129.GB7208@flint.arm.linux.org.uk>
Russell King wrote:
>The third parameter is obsolete and should only be used to select _one_
>of the tree suspend calls you will get.
>
>Any additional suspend calls should _not_ create extra usage of this
>parameter. It's a left over from Pat's first driver model incarnation
>which is specific to the platform device drivers. (Mainly it exists
>because no one can be bothered to clean it up.)
>
>
>
Oops... I mixed it with state parameter.
We need to track down the state parameter to setup wakeups.
The mixture was mostly provocated by using 'pm_message_t' instead of
'state' in David's suspend fucntion which doesn't look right to me by
itself.
Vitaly
next prev parent reply other threads:[~2005-10-05 9:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-04 18:02 [PATCH/RFC 1/2] simple SPI framework David Brownell
2005-10-05 8:06 ` Vitaly Wool
2005-10-05 9:01 ` Russell King
2005-10-05 9:13 ` Vitaly Wool [this message]
2005-10-05 14:39 ` David Brownell
2005-10-06 18:23 ` Mark Underwood
2005-10-06 18:29 ` Russell King
2005-10-06 19:02 ` [PATCH] Get rid of the obsolete tri-level suspend/resume callbacks (was: Re: [PATCH/RFC 1/2] simple SPI framework) Russell King
2005-10-06 19:09 ` Greg KH
2005-10-06 21:14 ` Pavel Machek
2005-10-06 21:19 ` Russell King
2005-10-05 9:30 ` [PATCH/RFC 1/2] simple SPI framework Adam Belay
2005-10-05 14:45 ` David Brownell
2005-10-05 11:10 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4343994B.6060306@ru.mvista.com \
--to=vwool@ru.mvista.com \
--cc=basicmark@yahoo.com \
--cc=david-b@pacbell.net \
--cc=dpervushin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=stephen@streetfiresound.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox