public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jon Burgess <jburgess@uklinux.net>
To: kenneth.w.chen@intel.com
Cc: Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org, linux-netdev@vger.kernel.org
Subject: Re: kernel performance update - 2.6.14-rc3
Date: Sat, 08 Oct 2005 01:49:59 +0100	[thread overview]
Message-ID: <434717B7.30505@uklinux.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

"Chen, Kenneth W" <kenneth.w.chen@intel.com> writes:

 > Even though
 > softirq is invoked at the end of dev_queue_xmit() via local_bh_enable(),
 > not all execution of softirq will result a __wake_up().  With higher
 > HZ rate, timer interrupt is more frequent and thus more softirq
 > invocation and leads to more __wake_up(), which then takes us to higher
 > throughput because cpu spend less time in idle.

Since the loopback xmit->rx path probably isn't being called in 
interrupt context might something like the patch below be needed?

Please forgive me if this is wrong, i've not even tried compiling this 
change let alone tested it.

	Jon



[-- Attachment #2: loopback-netif_rx.patch --]
[-- Type: text/x-patch, Size: 314 bytes --]

--- linux-2.6.13/drivers/net/loopback.c-orig	2005-10-08 01:32:50.000000000 +0100
+++ linux-2.6.13/drivers/net/loopback.c	2005-10-08 01:33:32.000000000 +0100
@@ -153,7 +153,7 @@ static int loopback_xmit(struct sk_buff 
 	lb_stats->tx_packets++;
 	put_cpu();
 
-	netif_rx(skb);
+	netif_rx_ni(skb);
 
 	return(0);
 }

             reply	other threads:[~2005-10-08  0:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-08  0:49 Jon Burgess [this message]
2005-10-08  1:38 ` kernel performance update - 2.6.14-rc3 Chen, Kenneth W
  -- strict thread matches above, loose matches on Subject: below --
2005-10-05 21:15 Chen, Kenneth W
2005-10-06  6:16 ` Arjan van de Ven
2005-10-06 10:04   ` Nick Piggin
2005-10-06 18:36     ` Chen, Kenneth W
2005-10-06 19:24       ` Sonny Rao
2005-10-06 19:32         ` Chen, Kenneth W
2005-10-06 10:32 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=434717B7.30505@uklinux.net \
    --to=jburgess@uklinux.net \
    --cc=ak@suse.de \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox