public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Dallas's 1-wire bus compile error (again)
@ 2005-10-13 18:23 Christian
  2005-10-13 18:33 ` Evgeniy Polyakov
  0 siblings, 1 reply; 6+ messages in thread
From: Christian @ 2005-10-13 18:23 UTC (permalink / raw)
  To: linux-kernel; +Cc: johnpol

[-- Attachment #1: Type: text/plain, Size: 519 bytes --]

hi,

playing around with "make randconfig" (don't ask :)), i noticed the
driver for the "Dallas's 1-wire bus" does not compile when CONFIG_NET is 
disabled.

this was discussed earlier in

   http://www.ussg.iu.edu/hypermail/linux/kernel/0408.1/1764.html

but the discussion ended up in arguing about using "depends" over 
"select" and the actual fix was forgotten i think.

Signed-off-by: Christian Kujau <evil@g-house.de>

thanks,
Christian.
-- 
BOFH excuse #446:

Mailer-daemon is busy burning your message in hell.

[-- Attachment #2: dallas-1-wire_compile-fix.diff --]
[-- Type: text/plain, Size: 373 bytes --]

--- linux-2.6/drivers/w1/Kconfig.orig	2005-10-13 20:09:44.813986698 +0200
+++ linux-2.6/drivers/w1/Kconfig	2005-10-13 20:10:21.613460153 +0200
@@ -2,6 +2,7 @@ menu "Dallas's 1-wire bus"
 
 config W1
 	tristate "Dallas's 1-wire support"
+	depends on NET
 	---help---
 	  Dallas's 1-wire bus is usefull to connect slow 1-pin devices
 	  such as iButtons and thermal sensors.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] Dallas's 1-wire bus compile error (again)
@ 2005-10-13 18:27 Christian
  0 siblings, 0 replies; 6+ messages in thread
From: Christian @ 2005-10-13 18:27 UTC (permalink / raw)
  To: linux-kernel; +Cc: johnpol

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]


...and again with some spelling fixes. sorry for the noise.

Signed-off-by: Christian Kujau <evil@g-house.de>

thanks,
Christian.
-- 
BOFH excuse #446:

Mailer-daemon is busy burning your message in hell.


[-- Attachment #2: dallas-1-wire_compile-fix_2.diff --]
[-- Type: text/plain, Size: 996 bytes --]

--- linux-2.6/drivers/w1/Kconfig.orig	2005-10-13 20:09:44.813986698 +0200
+++ linux-2.6/drivers/w1/Kconfig	2005-10-13 20:26:22.349713477 +0200
@@ -2,8 +2,9 @@ menu "Dallas's 1-wire bus"
 
 config W1
 	tristate "Dallas's 1-wire support"
+	depends on NET
 	---help---
-	  Dallas's 1-wire bus is usefull to connect slow 1-pin devices
+	  Dallas's 1-wire bus is useful to connect slow 1-pin devices
 	  such as iButtons and thermal sensors.
 
 	  If you want W1 support, you should say Y here.
@@ -44,7 +45,7 @@ config W1_THERM
 	tristate "Thermal family implementation"
 	depends on W1
 	help
-	  Say Y here if you want to connect 1-wire thermal sensors to you
+	  Say Y here if you want to connect 1-wire thermal sensors to your
 	  wire.
 
 config W1_SMEM
@@ -52,6 +53,6 @@ config W1_SMEM
 	depends on W1
 	help
 	  Say Y here if you want to connect 1-wire
-	  simple 64bit memory rom(ds2401/ds2411/ds1990*) to you wire.
+	  simple 64bit memory rom(ds2401/ds2411/ds1990*) to your wire.
 
 endmenu

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2005-10-13 20:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-13 18:23 [PATCH] Dallas's 1-wire bus compile error (again) Christian
2005-10-13 18:33 ` Evgeniy Polyakov
2005-10-13 19:20   ` Christian
2005-10-13 19:47     ` Evgeniy Polyakov
2005-10-13 20:14       ` Christian
  -- strict thread matches above, loose matches on Subject: below --
2005-10-13 18:27 Christian

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox