From: Jeff Garzik <jgarzik@pobox.com>
To: Michael Buesch <mbuesch@freenet.de>
Cc: James Ketrenos <jketreno@linux.intel.com>,
ieee80211-devel@lists.sourceforge.net,
bcm43xx-dev@lists.berlios.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH ieee80211] fix TX skb allocation flags and size
Date: Thu, 13 Oct 2005 19:04:27 -0400 [thread overview]
Message-ID: <434EE7FB.9010506@pobox.com> (raw)
In-Reply-To: <200510132341.56670.mbuesch@freenet.de>
Michael Buesch wrote:
> @@ -221,11 +221,13 @@ static struct ieee80211_txb *ieee80211_a
> txb->frag_size = txb_size;
>
> for (i = 0; i < nr_frags; i++) {
> - txb->fragments[i] = dev_alloc_skb(txb_size);
> + txb->fragments[i] = __dev_alloc_skb(txb_size + headroom,
> + gfp_mask | GFP_DMA);
> if (unlikely(!txb->fragments[i])) {
> i--;
Very wrong. GFP_DMA means ISA DMA.
See pci_map_xxx() and other DMA API functions.
Jeff
next prev parent reply other threads:[~2005-10-13 23:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-13 21:41 [PATCH ieee80211] fix TX skb allocation flags and size Michael Buesch
2005-10-13 23:04 ` Jeff Garzik [this message]
2005-10-13 23:17 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434EE7FB.9010506@pobox.com \
--to=jgarzik@pobox.com \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=ieee80211-devel@lists.sourceforge.net \
--cc=jketreno@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbuesch@freenet.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox