From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Len Brown <len.brown@intel.com>,
iss_storagedev@hp.com, Jakub Jelinek <jj@ultra.linux.cz>,
Frodo Looijaard <frodol@dds.nl>,
Jean Delvare <khali@linux-fr.org>,
Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
Jens Axboe <axboe@suse.de>, Roland Dreier <rolandd@cisco.com>,
Sergio Rozanski Filho <aris@cathedrallabs.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Pierre Ossman <drzeus-wbsd@drzeus.cx>,
Carsten Gross <carsten@sol.wh-hms.uni-ulm.de>,
Greg Kroah-Hartman <greg@kroah.com>,
David Hinds <dahinds@users.sourceforge.net>,
Vinh Truong <vinh.truong@eng.sun.com>,
Mark Douglas Corner <mcorner@umich.edu>,
Michael Downey <downey@zymeta.com>,
Antonino Daplas <adaplas@pol.net>,
Ben Gardner <bgardner@wabtec.com>
Subject: Re: [PATCH 09/14] Big kfree NULL check cleanup - misc remaining drivers
Date: Fri, 14 Oct 2005 06:54:54 +0200 [thread overview]
Message-ID: <434F3A1E.7000403@drzeus.cx> (raw)
In-Reply-To: <200510132128.45171.jesper.juhl@gmail.com>
Jesper Juhl wrote:
> This is the remaining misc drivers/ part of the big kfree cleanup patch.
>
> Remove pointless checks for NULL prior to calling kfree() in misc files in drivers/.
>
>
> Sorry about the long Cc: list, but I wanted to make sure I included everyone
> who's code I've changed with this patch.
>
>
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
> ---
>
> --- linux-2.6.14-rc4-orig/drivers/mmc/wbsd.c 2005-10-11 22:41:10.000000000 +0200
> +++ linux-2.6.14-rc4/drivers/mmc/wbsd.c 2005-10-12 15:43:04.000000000 +0200
> @@ -1595,8 +1595,7 @@ static void __devexit wbsd_release_dma(s
> if (host->dma_addr)
> dma_unmap_single(host->mmc->dev, host->dma_addr, WBSD_DMA_SIZE,
> DMA_BIDIRECTIONAL);
> - if (host->dma_buffer)
> - kfree(host->dma_buffer);
> + kfree(host->dma_buffer);
> if (host->dma >= 0)
> free_dma(host->dma);
>
Looks good. Thanks.
Acked-by: Pierre Ossman <drzeus@drzeus.cx>
next prev parent reply other threads:[~2005-10-14 4:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-13 19:28 [PATCH 09/14] Big kfree NULL check cleanup - misc remaining drivers Jesper Juhl
2005-10-13 19:37 ` Roland Dreier
2005-10-14 4:54 ` Pierre Ossman [this message]
2005-10-14 9:24 ` Jean Delvare
2005-10-14 9:46 ` Andrew Morton
2005-10-14 11:58 ` Jesper Juhl
2005-10-14 9:46 ` Jens Axboe
2005-10-14 18:12 ` Greg KH
2005-10-14 21:24 ` Antonino A. Daplas
-- strict thread matches above, loose matches on Subject: below --
2005-10-13 20:01 Miller, Mike (OS Dev)
2005-10-13 20:10 ` Jesper Juhl
2005-10-13 20:12 ` Roland Dreier
2005-10-13 20:30 ` Alistair John Strachan
2005-10-13 20:03 Brown, Len
2005-10-13 20:39 Miller, Mike (OS Dev)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434F3A1E.7000403@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=adaplas@pol.net \
--cc=akpm@osdl.org \
--cc=aris@cathedrallabs.org \
--cc=axboe@suse.de \
--cc=benh@kernel.crashing.org \
--cc=bgardner@wabtec.com \
--cc=carsten@sol.wh-hms.uni-ulm.de \
--cc=dahinds@users.sourceforge.net \
--cc=downey@zymeta.com \
--cc=drzeus-wbsd@drzeus.cx \
--cc=frodol@dds.nl \
--cc=greg@kroah.com \
--cc=iss_storagedev@hp.com \
--cc=jesper.juhl@gmail.com \
--cc=jj@ultra.linux.cz \
--cc=khali@linux-fr.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcorner@umich.edu \
--cc=rolandd@cisco.com \
--cc=vinh.truong@eng.sun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox