Re: Robust Futex update

[Khem Raj <kraj@mvista.com>]

Hi Ingo

As we pass same flags from glibc to kernel we thought it will be good to 
have defines in one place to avoid going out of sync in future.
glibc already has dependency on kernel headers. So were looking for ways 
to fix futex.h in kernel so that glibc can use it. But if it is not 
feasible then we can define these flags inside glibc headers. Only 
additional burden will be that these headers will be required to be 
synced whenever there is any change pertaining to them(mostly the defines.)

Thanks

Khem

Ingo Molnar wrote:

>* David Singleton <dsingleton@mvista.com> wrote:
>
>  
>
>>Index: linux-2.6.13/include/linux/futex.h
>>===================================================================
>>--- linux-2.6.13.orig/include/linux/futex.h
>>+++ linux-2.6.13/include/linux/futex.h
>>@@ -1,8 +1,6 @@
>> #ifndef _LINUX_FUTEX_H
>> #define _LINUX_FUTEX_H
>> 
>>-#include <linux/fs.h>
>>-
>> /* Second argument to futex syscall */
>> 
>>    
>>
>
>this chunk broke the build, so i added the #include back. Really, the 
>robust mutex glibc patches should _NOT_ automatically include the 
>kernel's futex.h file. If they do so and rely on an installed 
>kernel-headers package then they are broken. Just copy the file into the 
>glibc tree and remove the #include line.
>
>	Ingo
>  
>
>------------------------------------------------------------------------
>
>_______________________________________________
>robustmutexes mailing list
>robustmutexes@lists.osdl.org
>https://lists.osdl.org/mailman/listinfo/robustmutexes
>  
>

-- 
Khem Raj <kraj@mvista.com>
MontaVista Software, Inc.
www.mvista.com