Re: What is struct pci_driver.owner for?

[Jiri Slaby <jirislaby@gmail.com>]

Roland Dreier napsal(a):

>    Greg> But what it really does today is create the symlink from the
>    Greg> driver to the module that is contained in it, in sysfs.
>    Greg> Which is very invaluable for people who want to know these
>    Greg> things (installer programs, etc.)
>
>    Greg> That "module" symlink is created only if the .owner field is
>    Greg> set.  That's why people are going through and adding it to
>    Greg> all of the drivers in the system.
>
>OK, I'll make my own small contribution and push this for 2.6.15:
>  
>
Ok, but read Documentation/SubmittingPatches. At least Signed-off-by is
missing.

>diff --git a/drivers/infiniband/hw/mthca/mthca_main.c b/drivers/infiniband/hw/mthca/mthca_main.c
>--- a/drivers/infiniband/hw/mthca/mthca_main.c
>+++ b/drivers/infiniband/hw/mthca/mthca_main.c
>@@ -1196,6 +1196,7 @@ MODULE_DEVICE_TABLE(pci, mthca_pci_table
> 
> static struct pci_driver mthca_driver = {
> 	.name		= DRV_NAME,
>+	.owner		= THIS_MODULE,
> 	.id_table	= mthca_pci_table,
> 	.probe		= mthca_init_one,
> 	.remove		= __devexit_p(mthca_remove_one)
>  
>
regards,
-- 
Jiri Slaby         www.fi.muni.cz/~xslaby
~\-/~      jirislaby@gmail.com      ~\-/~
B67499670407CE62ACC8 22A032CC55C339D47A7E