Matt Mackall wrote:
> On Mon, Oct 24, 2005 at 12:29:45AM -0500, Hareesh Nagarajan wrote:
>> The existing code in init_tmpfs() in mm/tiny-shmem.c does not handle the 
>> cases when the calls to register_filesystem() and kern_mount() fail. 
>> This patch adds those checks.
> 
> Hmm. Did you actually encounter this?

No, I haven't. I was just reading the source code when I chanced upon 
these trivial error checking omissions.

> I'd rather use BUG_ON. Passing up errors is only useful when the code
> above can and will do something useful with the information. 

[ Snip ]

> And what could the higher level, which is simply looping through init
> functions, do to handle the error? Retry? Print a warning? Better to
> stop everything outright when we encounter a problem we expect should
> never happen so it doesn't go by undiagnosed.

Makes sense. New patch attached.

Signed-off-by: Hareesh Nagarajan <hnagar2@gmail.com>