From: "Vladimir V. Saveliev" <vs@namesys.com>
To: Andrew Morton <akpm@osdl.org>, andrea@suse.de
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: fix-nr_unused-accounting-and-avoid-recursing-in-iput-with-i_will_free-set.patch
Date: Tue, 25 Oct 2005 17:06:06 +0400 [thread overview]
Message-ID: <435E2DBE.70901@namesys.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
Hello
The patch mentioned in the subject checks I_WILL_FREE bit in inode->i_flags,
while generic_forget_inode sets it in inode->i_state.
Is it really supposed to be so?
If not, does the attached patch look correct?
[-- Attachment #2: writeback_single_inode-warn-fix.patch --]
[-- Type: text/plain, Size: 983 bytes --]
generic_forget_inode sets I_WILL_FREE bit in inode->i_state.
__writeback_single_inode checks that bit in inode->i_flags.
This patch changes __writeback_single_inode to check inode->i_state.
fs/fs-writeback.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -puN fs/fs-writeback.c~writeback_single_inode-warn-fix fs/fs-writeback.c
--- linux-2.6.14-rc5-mm1/fs/fs-writeback.c~writeback_single_inode-warn-fix 2005-10-25 15:52:13.857616000 +0400
+++ linux-2.6.14-rc5-mm1-root/fs/fs-writeback.c 2005-10-25 15:52:37.051065500 +0400
@@ -248,9 +248,9 @@ __writeback_single_inode(struct inode *i
wait_queue_head_t *wqh;
if (!atomic_read(&inode->i_count))
- WARN_ON(!(inode->i_flags & I_WILL_FREE));
+ WARN_ON(!(inode->i_state & I_WILL_FREE));
else
- WARN_ON(inode->i_flags & I_WILL_FREE);
+ WARN_ON(inode->i_state & I_WILL_FREE);
if ((wbc->sync_mode != WB_SYNC_ALL) && (inode->i_state & I_LOCK)) {
list_move(&inode->i_list, &inode->i_sb->s_dirty);
_
reply other threads:[~2005-10-25 13:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=435E2DBE.70901@namesys.com \
--to=vs@namesys.com \
--cc=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox