From: <Hermes.Wu@ite.com.tw>
To: <dmitry.baryshkov@linaro.org>
Cc: <Kenneth.Hung@ite.com.tw>, <andrzej.hajda@intel.com>,
<neil.armstrong@linaro.org>, <rfoss@kernel.org>,
<Laurent.pinchart@ideasonboard.com>, <jonas@kwiboo.se>,
<jernej.skrabec@gmail.com>, <maarten.lankhorst@linux.intel.com>,
<mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>,
<simona@ffwll.ch>, <angelogioacchino.delregno@collabora.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 11/11] drm/bridge: it6505: Add aux i2c functionality
Date: Fri, 27 Sep 2024 02:43:36 +0000 [thread overview]
Message-ID: <4360d5a8c4e54540831eca77ca9156f5@ite.com.tw> (raw)
In-Reply-To: <loulf3p74x3p6dinublo6xenwjoyssm2f5rk5g3env54abhath@37i4vlvxjn3f>
>-----Original Message-----
>From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>Sent: Thursday, September 26, 2024 8:58 PM
>To: Hermes Wu (吳佳宏) <Hermes.Wu@ite.com.tw>
>Cc: Kenneth Hung (洪家倫) <Kenneth.Hung@ite.com.tw>; Andrzej Hajda <andrzej.hajda@intel.com>; Neil Armstrong <neil.armstrong@linaro.org>; Robert Foss <rfoss@kernel.org>; Laurent Pinchart <Laurent.pinchart@ideasonboard.com>; Jonas Karlman <jonas@kwiboo.se>; Jernej Skrabec <jernej.skrabec@gmail.com>; Maarten Lankhorst <maarten.lankhorst@linux.intel.com>; Maxime Ripard <mripard@kernel.org>; Thomas Zimmermann <tzimmermann@suse.de>; David Airlie <airlied@gmail.com>; Simona Vetter <simona@ffwll.ch>; AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>; Allen Chen <allen.chen@ite.com.tw>; open list:DRM DRIVERS <dri-devel@lists.freedesktop.org>; open list <linux-kernel@vger.kernel.org>
>Subject: Re: [PATCH v4 11/11] drm/bridge: it6505: Add aux i2c functionality
>
>On Thu, Sep 26, 2024 at 03:51:34PM GMT, Hermes Wu wrote:
>> From: Hermes Wu <Hermes.wu@ite.com.tw>
>>
>> Add aux-i2c operaction in order to support the MCCS function.
>
>Brevity is the soul of wit. However in the commit message we appreciate more details. Is it enough to get monitor control to work? Or is there anything left to be implemented?
In drm_dp_helper, drm_dp_i2c_xfer() pack I2C request into sequence of AUX request.
it6505_aux_i2c_operation() is implement to match drm_dp_i2c_xfer() behavior
>>
>>
>> Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
>
>This is definitely not a fix.
will remove.
>> Signed-off-by: Hermes Wu <Hermes.wu@ite.com.tw>
>> ---
>> drivers/gpu/drm/bridge/ite-it6505.c | 177
>> +++++++++++++++++++++++++++-
>> 1 file changed, 175 insertions(+), 2 deletions(-)
>
>--
>With best wishes
>Dmitry
>
BR,
Hermes
next prev parent reply other threads:[~2024-09-27 2:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 7:51 [PATCH v4 10/11] drm/bridge: it6505: fix HDCP CTS ksv wait timer Hermes Wu
2024-09-26 7:51 ` [PATCH v4 11/11] drm/bridge: it6505: Add aux i2c functionality Hermes Wu
2024-09-26 12:57 ` Dmitry Baryshkov
2024-09-27 2:43 ` Hermes.Wu [this message]
2024-09-27 8:36 ` Dmitry Baryshkov
2024-09-26 8:20 ` [PATCH v4 10/11] drm/bridge: it6505: fix HDCP CTS ksv wait timer Dmitry Baryshkov
2024-09-26 8:39 ` Hermes.Wu
2024-09-26 9:22 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4360d5a8c4e54540831eca77ca9156f5@ite.com.tw \
--to=hermes.wu@ite.com.tw \
--cc=Kenneth.Hung@ite.com.tw \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox