public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [patch 2/5] radix tree: use prealloc
Date: Sun, 30 Oct 2005 11:49:44 +1100	[thread overview]
Message-ID: <436418A8.9000505@yahoo.com.au> (raw)
In-Reply-To: <4364186F.60206@yahoo.com.au>

[-- Attachment #1: Type: text/plain, Size: 33 bytes --]

2/5

-- 
SUSE Labs, Novell Inc.


[-- Attachment #2: radix-tree-use-prealloc.patch --]
[-- Type: text/plain, Size: 1265 bytes --]

Prefer radix_tree_preloads to kmem_cache_alloc. If we've allocated them,
why not use them? They're also faster because they needn't turn off
interrupts, so using them in radix tree critical sections is a good idea.

Signed-off-by: Nick Piggin <npiggin@suse.de>

Index: linux-2.6/lib/radix-tree.c
===================================================================
--- linux-2.6.orig/lib/radix-tree.c
+++ linux-2.6/lib/radix-tree.c
@@ -82,20 +82,18 @@ DEFINE_PER_CPU(struct radix_tree_preload
 static struct radix_tree_node *
 radix_tree_node_alloc(struct radix_tree_root *root)
 {
-	struct radix_tree_node *ret;
-
-	ret = kmem_cache_alloc(radix_tree_node_cachep, root->gfp_mask);
-	if (ret == NULL && !(root->gfp_mask & __GFP_WAIT)) {
-		struct radix_tree_preload *rtp;
+	struct radix_tree_preload *rtp;
 
-		rtp = &__get_cpu_var(radix_tree_preloads);
-		if (rtp->nr) {
-			ret = rtp->nodes[rtp->nr - 1];
-			rtp->nodes[rtp->nr - 1] = NULL;
-			rtp->nr--;
-		}
+	rtp = &__get_cpu_var(radix_tree_preloads);
+	if (rtp->nr) {
+		struct radix_tree_node *ret;
+		ret = rtp->nodes[rtp->nr - 1];
+		rtp->nodes[rtp->nr - 1] = NULL;
+		rtp->nr--;
+		return ret;
 	}
-	return ret;
+
+	return kmem_cache_alloc(radix_tree_node_cachep, root->gfp_mask);
 }
 
 static inline void

  reply	other threads:[~2005-10-30  0:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-30  0:41 [patches] lockless pagecache prep round 1 Nick Piggin
2005-10-30  0:43 ` [patch 1/5] i386 generic cmpxchg Nick Piggin
2005-10-30  0:44   ` [patch 2/5] atomic: atomic_cmpxchg Nick Piggin
2005-10-30  0:45     ` [patch 3/5] atomic: atomic_inc_not_zero Nick Piggin
2005-10-30  0:45       ` [patch 4/5] rcu file: use atomic primitives Nick Piggin
2005-10-30  0:47         ` [patch 5/5] atomic: dec_and_lock " Nick Piggin
2005-10-31 19:05       ` [patch 3/5] atomic: atomic_inc_not_zero Christoph Lameter
2005-11-01  4:34         ` Nick Piggin
2005-11-14 16:29       ` Paul Jackson
2005-11-14 21:48         ` Andrew Morton
2005-11-14 22:02           ` Paul Jackson
2005-11-14 23:09             ` Andrew Morton
2005-11-15  8:57               ` Nick Piggin
2005-10-30 20:12   ` [patch 1/5] i386 generic cmpxchg Zwane Mwaikambo
2005-10-31  1:29     ` Nick Piggin
2005-10-31  6:06       ` Zwane Mwaikambo
2005-10-31 19:09       ` Christoph Lameter
2005-10-30  0:48 ` [patche 1/5] radix tree: lookup_slot Nick Piggin
2005-10-30  0:49   ` Nick Piggin [this message]
2005-10-30  0:50     ` [patch 3/5] radix tree: cleanup Nick Piggin
2005-10-30  0:51       ` [patch 4/5] radix tree: clear_tags bail Nick Piggin
2005-10-30  0:57         ` [patch 5/5] radix tree: shrink Nick Piggin
2005-10-30  1:04 ` [patch 1/5] radix tree: lookup_slot Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=436418A8.9000505@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox