Re: [PATCH]: Clean up of __alloc_pages

Christoph Lameter
2005-10-03T15:34:16Z

On Sat, 1 Oct 2005, Seth, Rohit wrote:

> - goto zone_reclaim_retry;
> - }
> + if (order == 0) {
> + for (i = 0; (z = zones[i]) != NULL; i++) {
> + page = buffered_rmqueue(z, 0, gfp_mask, 0);
> + if (page)
> + goto got_pg;
> }
> -

This is checking all zones for pages on the pcp before going the more
expensive route?

Seems that this removes the logic intended to prefer local
allocations over remote pages present in the existing alloc_pages? There
is the danger that this modification will lead to the allocation of remote
pages even if local pages are available. Thus reducing performance.

I would suggest to just check the first zone's pcp instead of all zones.