public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Christopher Friesen" <cfriesen@nortel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: madhu.subbaiah@wipro.com, linux-kernel@vger.kernel.org
Subject: Re: select() for delay.
Date: Mon, 31 Oct 2005 09:46:47 -0600	[thread overview]
Message-ID: <43663C67.2080902@nortel.com> (raw)
In-Reply-To: <200510302006.15892.arnd@arndb.de>

Arnd Bergmann wrote:
> On Maandag 24 Oktober 2005 12:55, madhu.subbaiah@wipro.com wrote:

>>This patch improves the sys_select() execution when used for delay. 

> Please describe what aspect of the syscall is improved. Is this only
> speeding up the execution for the delay case while slowing down
> the normal case, or do the actual semantics improve?

It appears to simply speed up the delay case.

One thing that I noticed though--the patch had the following line:

if ((n == 0) && (inp == NULL) && (outp == NULL) && (exp == NULL)) {


Would it be enought to just do the following?

if (n == 0) {

Given that if any of the fd_set pointers are non-empty, "n" ought to be 
non-zero, would this be a sufficient check?

Chris

      parent reply	other threads:[~2005-10-31 15:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-24 10:55 select() for delay madhu.subbaiah
2005-10-24 13:18 ` Steven Rostedt
2005-10-24 13:27   ` Arjan van de Ven
2005-10-24 13:37     ` Steven Rostedt
2005-10-25  6:26     ` Madhu K.S.
2005-10-30 19:06 ` Arnd Bergmann
2005-10-30 19:12   ` Arjan van de Ven
2005-10-31 15:46   ` Christopher Friesen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43663C67.2080902@nortel.com \
    --to=cfriesen@nortel.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madhu.subbaiah@wipro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox