From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Jordan Crouse <jordan.crouse@amd.com>
Cc: linux-kernel@vger.kernel.org, ralf.baechle@linux-mips.org,
ppopov@embeddedalley.com
Subject: Re: Au1xxx MMC driver
Date: Tue, 01 Nov 2005 11:05:16 +0100 [thread overview]
Message-ID: <43673DDC.6090303@drzeus.cx> (raw)
In-Reply-To: <20051031164021.GG20777@cosmic.amd.com>
Just a quick extra comment. It would be nice if you could use the host
controller name when doing the initial printk:
- printk(KERN_INFO DRIVER_NAME ": MMC Controller %d set up at
%8.8X (mode=%s)\n",
- host->id, host->iobase, dma ? "dma" : "pio");
+ printk(KERN_INFO "%s: MMC Controller %d set up at %8.8X
(mode=%s)\n",
+ mmc_hostname(mmc), host->id, host->iobase, dma ? "dma"
: "pio");
It gives a nice, visible connection between the host name and the hardware.
Rgds
Pierre
prev parent reply other threads:[~2005-11-01 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-31 16:40 Au1xxx MMC driver Jordan Crouse
2005-10-31 16:59 ` Pierre Ossman
2005-11-01 10:05 ` Pierre Ossman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43673DDC.6090303@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=jordan.crouse@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ppopov@embeddedalley.com \
--cc=ralf.baechle@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox