public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Fusion-MPT slowness workaround
@ 2005-11-01 17:46 Martin Devera
  0 siblings, 0 replies; 3+ messages in thread
From: Martin Devera @ 2005-11-01 17:46 UTC (permalink / raw)
  To: linux-kernel
  Cc: phil, akpm, Eric.Moore, Holger.Kiehl, James.Bottomley,
	artur.kedzierski

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

Hello,

because I ran into problem with fusion mpt scsi with 2.6.14 yesterday
I tried to find a workaround.
Because it seems that there is bug in DV code I patched driver to skip
DV and use firmware negotiation data.
It "works for me" both compiled-in and as module.

I tried to Cc all ppl who were working on the issue in past.

Martin Devera aka devik

[-- Attachment #2: mpt-dv-off.diff --]
[-- Type: text/plain, Size: 1674 bytes --]

diff -urpb linux-2.6.14/drivers/message/fusion/mptscsih.c drivers/message/fusion/mptscsih.c
--- linux-2.6.14/drivers/message/fusion/mptscsih.c	Fri Oct 28 02:02:08 2005
+++ drivers/message/fusion/mptscsih.c	Tue Nov  1 15:27:23 2005
@@ -163,10 +163,10 @@ static int	mptscsih_synchronize_cache(MP
 
 static struct work_struct   mptscsih_persistTask;
 
+static int	mptscsih_is_phys_disk(MPT_ADAPTER *ioc, int id);
 #ifdef MPTSCSIH_ENABLE_DOMAIN_VALIDATION
 static int	mptscsih_do_raid(MPT_SCSI_HOST *hd, u8 action, INTERNAL_CMD *io);
 static void	mptscsih_domainValidation(void *hd);
-static int	mptscsih_is_phys_disk(MPT_ADAPTER *ioc, int id);
 static void	mptscsih_qas_check(MPT_SCSI_HOST *hd, int id);
 static int	mptscsih_doDv(MPT_SCSI_HOST *hd, int channel, int target);
 static void	mptscsih_dv_parms(MPT_SCSI_HOST *hd, DVPARAMETERS *dv,void *pPage);
@@ -4196,7 +4196,7 @@ mptscsih_domainValidation(void *arg)
 
 	return;
 }
-
+#endif
 /* Search IOC page 3 to determine if this is hidden physical disk
  */
 /* Search IOC page 3 to determine if this is hidden physical disk
@@ -4216,6 +4216,7 @@ mptscsih_is_phys_disk(MPT_ADAPTER *ioc, 
 
 	return 0;
 }
+#ifdef MPTSCSIH_ENABLE_DOMAIN_VALIDATION
 
 /* Write SDP1 if no QAS has been enabled
  */
diff -urpb linux-2.6.14/drivers/message/fusion/mptscsih.h drivers/message/fusion/mptscsih.h
--- linux-2.6.14/drivers/message/fusion/mptscsih.h	Fri Oct 28 02:02:08 2005
+++ drivers/message/fusion/mptscsih.h	Tue Nov  1 15:24:55 2005
@@ -67,7 +67,7 @@
  * capabilities.
  */
 
-#define MPTSCSIH_ENABLE_DOMAIN_VALIDATION
+//#define MPTSCSIH_ENABLE_DOMAIN_VALIDATION
 
 
 /* SCSI driver setup structure. Settings can be overridden


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: Fusion-MPT slowness workaround
@ 2005-11-01 18:02 Moore, Eric Dean
  2005-11-01 18:11 ` Martin Devera
  0 siblings, 1 reply; 3+ messages in thread
From: Moore, Eric Dean @ 2005-11-01 18:02 UTC (permalink / raw)
  To: Martin Devera, linux-kernel
  Cc: phil, akpm, Moore, Eric Dean, Holger.Kiehl, James.Bottomley,
	artur.kedzierski

On Tuesday, November 01, 2005 10:46 AM,  Martin Devera wrote:
> because I ran into problem with fusion mpt scsi with 2.6.14 yesterday
> I tried to find a workaround.
> Because it seems that there is bug in DV code I patched driver to skip
> DV and use firmware negotiation data.
> It "works for me" both compiled-in and as module.
> 

NACK. Disabling DV is not the solution.

I have a fix I will post sometime this week.

Eric Moore

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Fusion-MPT slowness workaround
  2005-11-01 18:02 Fusion-MPT slowness workaround Moore, Eric Dean
@ 2005-11-01 18:11 ` Martin Devera
  0 siblings, 0 replies; 3+ messages in thread
From: Martin Devera @ 2005-11-01 18:11 UTC (permalink / raw)
  To: Moore, Eric Dean; +Cc: linux-kernel

Moore, Eric Dean wrote:
> On Tuesday, November 01, 2005 10:46 AM,  Martin Devera wrote:
> 
>>because I ran into problem with fusion mpt scsi with 2.6.14 yesterday
>>I tried to find a workaround.
>>Because it seems that there is bug in DV code I patched driver to skip
>>DV and use firmware negotiation data.
>>It "works for me" both compiled-in and as module.
>>
> 
> 
> NACK. Disabling DV is not the solution.
> 
> I have a fix I will post sometime this week.

excellent. Just to make it clear, I posted this one as quick workaround not
as final solution attempt.
Please consider CCing me when the patch will be available - I'll be pleased
to test it :-)

Martin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-11-01 18:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-01 18:02 Fusion-MPT slowness workaround Moore, Eric Dean
2005-11-01 18:11 ` Martin Devera
  -- strict thread matches above, loose matches on Subject: below --
2005-11-01 17:46 Martin Devera

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox