Re: [PATCH 26/37] dvb: add support for plls used by nxt200x

[Manu Abraham <manu@linuxtv.org>]

Mike Krufky wrote:

> Andrew Morton wrote:
>
>> Michael Krufky <mkrufky@m1k.net> wrote:
>>  
>>
>>> +struct dvb_pll_desc dvb_pll_tdhu2 = {
>>> +    .name = "ALPS TDHU2",
>>> +    .min = 54000000,
>>> +    .max = 864000000,
>>> +    .count = 4,
>>> +    .entries = {
>>> +        { 162000000, 44000000, 62500, 0x85, 0x01 },
>>> +        { 426000000, 44000000, 62500, 0x85, 0x02 },
>>> +        { 782000000, 44000000, 62500, 0x85, 0x08 },
>>> +        { 999999999, 44000000, 62500, 0x85, 0x88 },
>>> +    }
>>> +};
>>> +EXPORT_SYMBOL(dvb_pll_tdhu2);
>>>   
>>
>>
>> The new driver is to have a GPL license, I assume?
>>
>> Generally, EXPORT_SYMBOL_GPL seems more appropriate for the DVB 
>> subsystem.
>>

Hello Andrew,

We have in the DVB subsystem most of the exported symbols as 
EXPORT_SYMBOL itself, rather than EXPORT_SYMBOL_GPL. I think if this 
needs to be changed, we would require a global change of all symbols to 
the same to maintain consistency. If you require that change we can have 
a change but i would think that the discussions be done with the 
relevant copyright holders too, eventhough probably most of the authors 
won't have any objection.

> Yes, GPL'd of course.  But these pll definitions are not strictly tied 
> to nxt200x -- they may very well be used by another frontend module in 
> the future.
>
> Actually, we keep pll info in a separate file (dvb-pll.c) so that the 
> tuner programming can be used by any frontend module, depending on the 
> design..... About EXPORT_SYMBOL, this is how it's done all over dvb-pll.c
>
> If this needs to change, then it should apply to the entire dvb-pll.
>

It is not necessary limited to dvb-pll, but the entire dvb-kernel.


Thanks,
Manu