public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Krufky <mkrufky@m1k.net>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, linux-dvb-maintainer@linuxtv.org,
	Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH 04/37] dvb: Add ATSC support for DViCO FusionHDTV5 Lite
Date: Thu, 03 Nov 2005 23:01:34 -0500	[thread overview]
Message-ID: <436ADD1E.9080907@m1k.net> (raw)
In-Reply-To: <20051103132914.64e971b9.akpm@osdl.org>

Andrew Morton wrote:

>Michael Krufky <mkrufky@m1k.net> wrote:
>  
>
>>+static int tdvs_tua6034_pll_set(struct dvb_frontend* fe, struct dvb_frontend_parameters* params)
>> +{
>> +	struct dvb_bt8xx_card *card = (struct dvb_bt8xx_card *) fe->dvb->priv;
>>    
>>
>
>The cast of a void* is unneeded.  It's actually undesirable: if someone
>were to convert the thing-being-casted to some other scalar type, the cast
>would prevent the desired compiler warning.
>
Alexey Dobriyan wrote:

>Please, also
>
>	struct dvb_frontend *fe, struct dvb_frontend_parameters *params)
>			   ^				       ^
>
Both of these problems are all over dvb-kernel... We'll fix it up.

Thanks,

Michael Krufky

      parent reply	other threads:[~2005-11-04  4:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-01  8:12 [PATCH 04/37] dvb: Add ATSC support for DViCO FusionHDTV5 Lite Michael Krufky
2005-11-03  2:29 ` Andrew Morton
2005-11-03 19:10   ` Alexey Dobriyan
2005-11-04  4:01   ` Michael Krufky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=436ADD1E.9080907@m1k.net \
    --to=mkrufky@m1k.net \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-dvb-maintainer@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox