public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pierre Ossman <drzeus-list@drzeus.cx>
To: dtor_core@ameritech.net
Cc: Andrew Morton <akpm@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Adam Belay <ambx1@neo.rr.com>
Subject: Re: [Fwd: [PATCH] [PNP][RFC] Suspend support for PNP bus.]
Date: Fri, 04 Nov 2005 16:52:57 +0100	[thread overview]
Message-ID: <436B83D9.8@drzeus.cx> (raw)
In-Reply-To: <d120d5000511040727x7d433e08jeb8937cb2e48249a@mail.gmail.com>

Dmitry Torokhov wrote:
> On 11/4/05, Pierre Ossman <drzeus-list@drzeus.cx> wrote:
>   
>> Dmitry Torokhov wrote:
>>     
>>> Hmm, would'nt presence of such device stop suspend process? It will
>>> cause pnp_bus_resume to fail too. Perhaps returning 0 in this case is
>>> better.
>>>
>>>
>>>       
>> The problem is that this code is also visited from pnp_activate_dev() &
>> co where this return value is needed. For pnp_stop_dev() the same check
>> (pnp_can_disable()) is performed in the suspend routine to avoid that
>> particular problem. For resume my assumption was that a device that
>> doesn't support activation will not have a driver attached to it.
>> Perhaps this is wrong?
>>
>>     
>
> i8042 registers drivers for keyboard and AUX ports to gather
> information whether the ports are present and what IRQ and IO ports
> shoudl be used to access them. And I have seen a few boxes that do not
> alloe [de]activate these devices.
>
>   

But the activation is performed by the PNP layer when the driver is 
matched with a driver. So the driver isn't really responsible for the 
activation. It can prevent activation through 
PNP_DRIVER_RES_DO_NOT_CHANGE though, but that flag is also checked in 
the suspend routines.

Rgds
Pierre

  reply	other threads:[~2005-11-04 15:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-04  9:21 [Fwd: [PATCH] [PNP][RFC] Suspend support for PNP bus.] Pierre Ossman
2005-11-04 14:49 ` Dmitry Torokhov
2005-11-04 15:16   ` Pierre Ossman
2005-11-04 15:27     ` Dmitry Torokhov
2005-11-04 15:52       ` Pierre Ossman [this message]
2005-11-04 16:09         ` Dmitry Torokhov
2005-11-04 16:12           ` Dmitry Torokhov
2005-11-05  7:15             ` Andrew Morton
2005-11-06 16:50               ` Dmitry Torokhov
2005-11-29 19:32 ` Andrew Morton
2005-11-29 18:50   ` Pierre Ossman
2005-11-29 20:02     ` Andrew Morton
2005-11-29 19:49       ` Pierre Ossman
2005-11-29 21:01         ` Andrew Morton
2005-11-29 20:44           ` Pierre Ossman
2005-11-30 10:12           ` Pierre Ossman
2005-11-30 10:44         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=436B83D9.8@drzeus.cx \
    --to=drzeus-list@drzeus.cx \
    --cc=akpm@osdl.org \
    --cc=ambx1@neo.rr.com \
    --cc=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox