From: Corey Minyard <minyard@acm.org>
To: paulmck@us.ibm.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix remaining list_for_each_safe_rcu in -mm
Date: Fri, 04 Nov 2005 22:01:18 -0600 [thread overview]
Message-ID: <436C2E8E.9040909@acm.org> (raw)
In-Reply-To: <20051101152933.GA6210@us.ibm.com>
Sorry for the long delay, I've been travelling and giving presentations :(.
IIRC, the RCU operations are "safe" by nature, so this is fine.
-Corey
Paul E. McKenney wrote:
>Hello!
>
>I missed a use of list_for_each_rcu_safe() in -mm tree. Here is a patch
>to fix it.
>
>Signed-off-by: <paulmck@us.ibm.com>
>
>---
>
> ipmi_msghandler.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
>diff -urpNa -X dontdiff linux-2.6.14-rc5-mm1/drivers/char/ipmi/ipmi_msghandler.c linux-2.6.14-rc5-mm1-safe_rcu/drivers/char/ipmi/ipmi_msghandler.c
>--- linux-2.6.14-rc5-mm1/drivers/char/ipmi/ipmi_msghandler.c 2005-11-01 06:44:09.000000000 -0800
>+++ linux-2.6.14-rc5-mm1-safe_rcu/drivers/char/ipmi/ipmi_msghandler.c 2005-11-01 07:00:50.000000000 -0800
>@@ -788,7 +788,7 @@ int ipmi_destroy_user(ipmi_user_t user)
> int i;
> unsigned long flags;
> struct cmd_rcvr *rcvr;
>- struct list_head *entry1, *entry2;
>+ struct list_head *entry1;
> struct cmd_rcvr *rcvrs = NULL;
>
> user->valid = 1;
>@@ -813,8 +813,7 @@ int ipmi_destroy_user(ipmi_user_t user)
> * synchronize_rcu()) then free everything in that list.
> */
> spin_lock_irqsave(&intf->cmd_rcvrs_lock, flags);
>- list_for_each_safe_rcu(entry1, entry2, &intf->cmd_rcvrs) {
>- rcvr = list_entry(entry1, struct cmd_rcvr, link);
>+ list_for_each_entry_rcu(entry1, &intf->cmd_rcvrs, link) {
> if (rcvr->user == user) {
> list_del_rcu(&rcvr->link);
> rcvr->next = rcvrs;
>
>
prev parent reply other threads:[~2005-11-05 4:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-01 15:29 [PATCH] fix remaining list_for_each_safe_rcu in -mm Paul E. McKenney
2005-11-01 16:17 ` [PATCH] fix remaining list_for_each_safe_rcu in -mm (take 2) Paul E. McKenney
2005-11-05 4:01 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=436C2E8E.9040909@acm.org \
--to=minyard@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox