Re: [PATCH 10/25] fs: move ext2 ioctl32 handlers into file systems

Christoph Hellwig
2005-11-06T04:40:12Z

On Sat, Nov 05, 2005 at 05:27:00PM +0100, Arnd Bergmann wrote:
> The same ioctls (originally from ext2) are used on ext2, ext3,
> hfsplus, cifs, reiserfs and xfs. Since they are really compatible
> between 32 and 64 bit except for the ioctl number, the conversion
> handler is trivial and I copy it to each of these file systems
> in order to eventually get rid of fs/compat_ioctl.c completely.

NACK, this is completely idiotic. Duplicating handlers is the very
last thing we want. I actually have patches to move handling some
of those ioctls into generic code, but that's a different story.