Re: [PATCH 13/25] loop: move ioctl32 code to loop.c

Christoph Hellwig
2005-11-07T03:33:26Z

On Sat, Nov 05, 2005 at 05:27:03PM +0100, Arnd Bergmann wrote:
> The loop device driver is the only user of its ioctl
> commands, so we can move the conversion handlers
> for 32 bit emulation into the driver itself.
>
> This patch just moves over the function, it would
> probably be a good idea to get rid of get_fs/set_fs
> calls here by integrating better with the driver.

Yes. just moving over is pointless. for things like loop where
there's just one driver implementing the api moving it there does
make sense, but please bring the compat layer up to standards first.