Re: [PATCH 12/25] scsi: move SG_IO ioctl32 code to sg.c

James Bottomley
2005-11-05T16:45:07Z

On Sat, 2005-11-05 at 17:27 +0100, Arnd Bergmann wrote:
> plain text document attachment (sg-ioctl.diff)
> The sg driver already has a compat_ioctl function, so the
> conversion handler for SG_IO can easily be moved in there
> as well. It still uses compat_alloc_user_space, so it can
> probably be simplified by using merging the conversion
> handler with the native method.

This is the wrong place, isn't it? SG_IO is also in
drivers/block/scsi_ioctl.c which isn't modular, so shouldn't this be in
there?

James