The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org,
	mlang@debian.org
Subject: Re: [PATCH] Set the vga cursor even when hidden
Date: Sun, 06 Nov 2005 10:11:26 +0800	[thread overview]
Message-ID: <436D664E.9030109@gmail.com> (raw)
In-Reply-To: <20051106004451.GF8183@bouh.residence.ens-lyon.fr>

Samuel Thibault wrote:
> Hi,
> 
> Antonino A. Daplas, le Sun 06 Nov 2005 08:37:27 +0800, a écrit :
>> Why not use this method (scanline_end < scanline_start) for VGA, and
>> the default method (moving the cursor out of the screen) for the rest?
> 
> Well, visually impaired people might want to use other cards as well.

See Linus's comments about that :-)

> 
>> Or why not just set bit 5 of the cursor start register (port 0x0a) to disable
>> the cursor, and clear to enable? I believe this will also work for the
>> other types.
> 
> If this works, it would be fine.

No, forget about that.  It sounds simple, but when the cursor is moved, the
cursor is unavoidably reenabled again (in vgacon_set_cursor_size). So this method
will require more work for what's it worth. Your patch is much simpler and uses
known working code. 

Tony



  reply	other threads:[~2005-11-06  2:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-05 21:19 [PATCH] Set the vga cursor even when hidden Samuel Thibault
2005-11-05 21:26 ` [PATCH 2.4] " Samuel Thibault
2005-11-06  0:37 ` [PATCH] " Antonino A. Daplas
2005-11-06  0:44   ` Samuel Thibault
2005-11-06  2:11     ` Antonino A. Daplas [this message]
2005-11-06  0:45   ` Linus Torvalds
2005-11-06  1:40     ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=436D664E.9030109@gmail.com \
    --to=adaplas@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlang@debian.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox