public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Linux Kernel Mailing List <Linux-Kernel@vger.kernel.org>
Subject: [patch 3/14] mm: release opt
Date: Sun, 06 Nov 2005 19:21:37 +1100	[thread overview]
Message-ID: <436DBD11.8010600@yahoo.com.au> (raw)
In-Reply-To: <436DBCE2.4050502@yahoo.com.au>

[-- Attachment #1: Type: text/plain, Size: 34 bytes --]

3/14

-- 
SUSE Labs, Novell Inc.


[-- Attachment #2: mm-release-opt.patch --]
[-- Type: text/plain, Size: 1495 bytes --]

Optimise some pagevec functions by not reenabling irqs while
switching lru locks.

Index: linux-2.6/mm/swap.c
===================================================================
--- linux-2.6.orig/mm/swap.c
+++ linux-2.6/mm/swap.c
@@ -220,10 +220,13 @@ void release_pages(struct page **pages, 
 
 		pagezone = page_zone(page);
 		if (pagezone != zone) {
-			if (zone)
-				spin_unlock_irq(&zone->lru_lock);
+			spin_lock_prefetch(&pagezone->lru_lock);
+			if (!zone)
+				local_irq_disable();
+			else
+				spin_unlock(&zone->lru_lock);
 			zone = pagezone;
-			spin_lock_irq(&zone->lru_lock);
+			spin_lock(&zone->lru_lock);
 		}
 		if (TestClearPageLRU(page))
 			del_page_from_lru(zone, page);
@@ -297,10 +300,12 @@ void __pagevec_lru_add(struct pagevec *p
 		struct zone *pagezone = page_zone(page);
 
 		if (pagezone != zone) {
+			if (!zone)
+				local_irq_disable();
 			if (zone)
-				spin_unlock_irq(&zone->lru_lock);
+				spin_unlock(&zone->lru_lock);
 			zone = pagezone;
-			spin_lock_irq(&zone->lru_lock);
+			spin_lock(&zone->lru_lock);
 		}
 		if (TestSetPageLRU(page))
 			BUG();
@@ -324,10 +329,12 @@ void __pagevec_lru_add_active(struct pag
 		struct zone *pagezone = page_zone(page);
 
 		if (pagezone != zone) {
+			if (!zone)
+				local_irq_disable();
 			if (zone)
-				spin_unlock_irq(&zone->lru_lock);
+				spin_unlock(&zone->lru_lock);
 			zone = pagezone;
-			spin_lock_irq(&zone->lru_lock);
+			spin_lock(&zone->lru_lock);
 		}
 		if (TestSetPageLRU(page))
 			BUG();

  reply	other threads:[~2005-11-06  8:19 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-06  8:11 [rfc][patch 0/14] mm: performance improvements Nick Piggin
2005-11-06  8:20 ` [patch 1/14] mm: opt rmqueue Nick Piggin
2005-11-06  8:20   ` [patch 2/14] mm: Nick Piggin
2005-11-06  8:20   ` [patch 2/14] mm: pte prefetch Nick Piggin
2005-11-06  8:21     ` Nick Piggin [this message]
2005-11-06  8:22       ` [patch 4/14] mm: rmap opt Nick Piggin
2005-11-06  8:23         ` [patch 5/14] mm: set_page_refs opt Nick Piggin
2005-11-06  8:24           ` [patch 6/14] mm: microopt conditions Nick Piggin
2005-11-06  8:24             ` [patch 7/14] mm: remove bad_range Nick Piggin
2005-11-06  8:25               ` [patch 8/14] mm: remove pcp_low Nick Piggin
2005-11-06  8:25                 ` [patch 9/14] mm: page_state opt Nick Piggin
2005-11-06  8:26                   ` [patch 10/14] mm: single pcp list Nick Piggin
2005-11-06  8:26                     ` [patch 11/14] mm: increase pcp size Nick Piggin
2005-11-06  8:27                       ` [patch 12/14] mm: variable " Nick Piggin
2005-11-06  8:27                         ` [patch 13/14] mm: cleanup zone_pcp Nick Piggin
2005-11-06  8:28                           ` [patch 14/14] mm: page_alloc cleanups Nick Piggin
2005-11-13  2:38                   ` [patch 9/14] mm: page_state opt Andi Kleen
2005-11-06 17:37               ` [patch 7/14] mm: remove bad_range Bob Picco
2005-11-07  0:58                 ` Nick Piggin
2005-11-07  3:00                   ` Bob Picco
2005-11-07  3:05                     ` Nick Piggin
2005-11-07  1:40           ` [patch 5/14] mm: set_page_refs opt Christoph Hellwig
2005-11-07  1:45             ` Nick Piggin
2005-11-06  8:35     ` [patch 2/14] mm: pte prefetch Arjan van de Ven
2005-11-06  8:51       ` Nick Piggin
2005-11-06 17:37   ` [patch 1/14] mm: opt rmqueue Andi Kleen
2005-11-07  1:06     ` Nick Piggin
2005-11-07  3:23       ` Andi Kleen
2005-11-07  3:43         ` Nick Piggin
2005-11-07  1:39 ` [rfc][patch 0/14] mm: performance improvements Christoph Hellwig
2005-11-07  1:51   ` Nick Piggin
2005-11-07  3:57     ` Paul Jackson
2005-11-07  4:51       ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=436DBD11.8010600@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=Linux-Kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox