Re: [PATCH] Eagle and ADI 930 usb adsl modem driver

[matthieu castet <castet.matthieu@free.fr>]

Hi Greg,

matthieu castet wrote:

>>> + *
>>> + * This software is available to you under a choice of one of two
>>> + * licenses. You may choose to be licensed under the terms of the GNU
>>> + * General Public License (GPL) Version 2, available from the file
>>> + * COPYING in the main directory of this source tree, or the
>>> + * BSD license below:
>>> + *
>>> + * Redistribution and use in source and binary forms, with or without
>>> + * modification, are permitted provided that the following conditions
>>> + * are met:
>>
>>
>>
>> <snip>  You don't need the whole GPL 2 copy here, just put the first
>> paragraph you have before this one in.
>>
> The paragraph you quote is the BSD licence, and point 1 is :
> Redistributions of source code must retain the above copyright
>  *    notice unmodified, this list of conditions, and the following
>  *    disclaimer
> 
> So could I remove it ?
> 
> 
>>
>>> diff -rNu -x '*.ko*' -x '*.mod*' -x '*.o*' 
>>> linux-2.6.14/drivers/usb/atm.old/ueagle-atm.h 
>>> linux-2.6.14/drivers/usb/atm/ueagle-atm.h
>>> --- linux-2.6.14/drivers/usb/atm.old/ueagle-atm.h    1970-01-01 
>>> 01:00:00.000000000 +0100
>>> +++ linux-2.6.14/drivers/usb/atm/ueagle-atm.h    2005-10-30 
>>> 00:25:27.000000000 +0200
>>
>>
>>
>> Why do you need a header file for a single .c file?
>>
> I think it makes things cleaner. I even like the bsd style where there 
> is an header for reg (hardware values) and an other for val (driver 
> structures).
> 

We patched our driver with the comments sent, but we still don't know 
what to do with this 2 points :
- For the license stuff, all the dual bsd/gpl drivers I saw in the 
kernel tree have the complete bsd header.
- For the header file I prefer a separate header file, but if Linux 
policy is to merge header and source file, that's fine.


Regards,

Matthieu