From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Neil Brown <neilb@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
dm-devel@redhat.com, heiko.carstens@de.ibm.com,
linux-kernel@vger.kernel.org, aherrman@de.ibm.com,
bunk@stusta.de, cplk@itee.uq.edu.au
Subject: Re: [dm-devel] Re: [PATCH resubmit] do_mount: reduce stack consumption
Date: Tue, 08 Nov 2005 12:37:30 +1100 [thread overview]
Message-ID: <4370015A.8010402@yahoo.com.au> (raw)
In-Reply-To: <17263.63845.556511.171582@cse.unsw.edu.au>
Neil Brown wrote:
> On Tuesday November 8, nickpiggin@yahoo.com.au wrote:
>>Possibly it could go into struct io_context?
>>
>
>
> My quick reading of the code says that we could have to
> allocate the struct right there in generic_make_request, and I don't
> think we can be certain that such an allocation will succeed.
>
> Code that uses io_context can limp along if it doesn't exist.
> The new generic_make_request needs this bio_list to be present
> or it cannot do it's job.
>
You can ask for the io context without having a request. However,
there is nothing like a mempool for them so code really should be
able to limp along without them.
I guess it would be silly to require such an allocation to succeed
here, because the block layer is pretty free of OOM deadlocks.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
prev parent reply other threads:[~2005-11-08 1:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 10:50 [PATCH resubmit] do_mount: reduce stack consumption Heiko Carstens
2005-11-04 11:48 ` Al Viro
2005-11-04 12:57 ` Heiko Carstens
2005-11-04 14:06 ` Al Viro
2005-11-04 22:03 ` Heiko Carstens
2005-11-04 16:48 ` Andrew Morton
2005-11-04 21:27 ` Heiko Carstens
2005-11-04 23:55 ` Adrian Bunk
2005-11-05 0:08 ` Andrew Morton
2005-11-05 1:15 ` cplk
2005-11-05 1:37 ` Andrew Morton
2005-11-05 5:37 ` Neil Brown
2005-11-07 0:16 ` [dm-devel] " Neil Brown
2005-11-07 16:15 ` Heiko Carstens
2005-11-07 22:12 ` Neil Brown
2005-11-07 23:37 ` Andrew Morton
2005-11-08 0:32 ` Nick Piggin
2005-11-08 1:03 ` Neil Brown
2005-11-08 1:15 ` Andrew Morton
2005-11-08 1:37 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4370015A.8010402@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=aherrman@de.ibm.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=cplk@itee.uq.edu.au \
--cc=dm-devel@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox