From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751410AbVKIPVO (ORCPT ); Wed, 9 Nov 2005 10:21:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751409AbVKIPVN (ORCPT ); Wed, 9 Nov 2005 10:21:13 -0500 Received: from rtsoft2.corbina.net ([85.21.88.2]:27784 "HELO mail.dev.rtsoft.ru") by vger.kernel.org with SMTP id S1751407AbVKIPVL (ORCPT ); Wed, 9 Nov 2005 10:21:11 -0500 Message-ID: <43721456.4070205@ru.mvista.com> Date: Wed, 09 Nov 2005 18:23:02 +0300 From: Sergei Shtylylov Organization: MostaVista Software Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 X-Accept-Language: ru, en-us, en-gb MIME-Version: 1.0 To: Alan Cox CC: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: PATCH: libata PATA patches References: <1131460386.25192.45.camel@localhost.localdomain> <4371FA47.1070806@ru.mvista.com> In-Reply-To: <4371FA47.1070806@ru.mvista.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hello, I wrote: > Alan Cox wrote: > >> I've put a new patch versus 2.6.14-mm1 on >> http://zeniv.linux.org.uk/~alan/IDE > > > I found somewhat strange that you check for 0xABCDExxx signature in > 32-bit PCI config. reg. 0x78 while HighPoint's own drivers read BM reg. > 0x90 (i.e. PCI config. 0x70) for that. PCI reg. 0x7A is DPLL precision > adjust reg. and 0x7B is the input clock select and IRQ reg., so it'd be > quite strange if the BIOS used them for any kind of signature... Pardon me for being too hasty. :-) I was talking about drivers/scsi/pata_hpt37x.c WBR, Sergei