From: "Jan Beulich" <JBeulich@novell.com>
To: "Adrian Bunk" <bunk@stusta.de>
Cc: "Gerd Knorr" <kraxel@suse.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] make vesafb build without CONFIG_MTRR
Date: Thu, 10 Nov 2005 09:24:40 +0100 [thread overview]
Message-ID: <437311D8.76F0.0078.0@novell.com> (raw)
In-Reply-To: <20051109215934.GD4047@stusta.de>
>>> Adrian Bunk <bunk@stusta.de> 09.11.05 22:59:35 >>>
>On Mon, Nov 07, 2005 at 01:53:30PM +0100, Jan Beulich wrote:
>
>> vesafb did not build without CONFIG_MTRR.
>>...
>
>I wasn't able to reproduce your problem.
>
>Please send the error message and the a complete .config for
reproducing
>it.
Hmm, yes. The change came from the Xen kernel, which for some reason
has CONFIG_MTRR but doesn't compile the respective source file on
x86-64. When I ran into that, I didn't realize that include/asm/mtrr.h
has wrappers for the !CONFIG_MTRR case.
But anyway, the code now framed by the conditionals is dead code
without CONFIG_MTRR anyway. So if the number of #ifdef-s is important
I'm OK with withrawing that patch, but then I'd like to see the same
happen in all the other frame buffer drivers (after all it was the fact
that the conditionals were there everywhere else I checked that made me
not look at include/asm/mtrr.h)...
Jan
prev parent reply other threads:[~2005-11-10 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-07 12:53 [PATCH] make vesafb build without CONFIG_MTRR Jan Beulich
2005-11-09 21:59 ` Adrian Bunk
2005-11-10 8:24 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=437311D8.76F0.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=bunk@stusta.de \
--cc=kraxel@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox