From: Michael Krufky <mkrufky@m1k.net>
To: mchehab@brturbo.com.br
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, video4linux-list@redhat.com
Subject: Re: [Patch 17/20] V4L (963.1) hybrid v4l/dvb: remove duplicated code
Date: Thu, 10 Nov 2005 16:25:30 -0500 [thread overview]
Message-ID: <4373BACA.7040503@m1k.net> (raw)
In-Reply-To: <1131656168.6478.52.camel@localhost>
mchehab@brturbo.com.br wrote:
>From: Michael Krufky <mkrufky@m1k.net>
>
>- The following patch caused a duplicated code in cx88-dvb.c
>
>Signed-off-by: Michael Krufky <mkrufky@m1k.net>
>
> drivers/media/video/cx88/cx88-dvb.c | 3 ---
> 1 files changed, 3 deletions(-)
>
Mauro chopped my description on this patch...... The description above
doesnt make any sense... It SHOULD read as follows:
The following patch caused some duplicated code in cx88-dvb.c:
[PATCH] v4l: 634: implemented tuner set standby on cx88 init
The cx88-dvb.c portion of this patch was already applied
in an earlier patch, entitled:
[PATCH] v4l: fixup on cx88_dvb for Dvico HDTV5 Gold
I love quilt and all, but AFAIK, no tool is 100% perfect for catching
oversights like this.
The non-overlapping portions of each of these patches are still needed,
and must not be discarded, so rather than reverting old patches, please
just apply this fixup patch to remove the duplicated code.
Signed-off-by: Michael Krufky <mkrufky@m1k.net>
Now, maybe my description was wordy, but the one-liner doesnt tell us
ANYTHING meaningful.
Thanks.
--
Michael Krufky
parent reply other threads:[~2005-11-10 21:26 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1131656168.6478.52.camel@localhost>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4373BACA.7040503@m1k.net \
--to=mkrufky@m1k.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@brturbo.com.br \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox