public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Krufky <mkrufky@linuxtv.org>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Mauro Carvalho Chehab <mchehab@brturbo.com.br>,
	Andrew Morton <akpm@osdl.org>,
	Linux and Kernel Video <video4linux-list@redhat.com>
Subject: Re: saa711x driver doesn't need segment.h
Date: Thu, 10 Nov 2005 17:20:36 -0500	[thread overview]
Message-ID: <4373C7B4.2000509@linuxtv.org> (raw)
In-Reply-To: <20051110221411.GA26539@redhat.com>

Dave Jones wrote:

>This breaks compilation on non-x86 architectures,
>and isn't even used.
>
>Signed-off-by: Dave Jones <davej@redhat.com>
>
>--- linux-2.6.14/drivers/media/video/saa711x.c~	2005-11-10 15:27:05.000000000 -0500
>+++ linux-2.6.14/drivers/media/video/saa711x.c	2005-11-10 15:27:33.000000000 -0500
>@@ -36,7 +36,6 @@
> #include <asm/pgtable.h>
> #include <asm/page.h>
> #include <linux/sched.h>
>-#include <asm/segment.h>
> #include <linux/types.h>
> #include <asm/uaccess.h>
> #include <linux/videodev.h>
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/
>  
>
Acked-by: Michael Krufky <mkrufky@m1k.net>

Andrew-

Due to the above fix, please revert:

saa711x-is-busted-on-ppc64.patch

Thank you.

-- 
Michael Krufky



  reply	other threads:[~2005-11-10 22:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-10 22:14 saa711x driver doesn't need segment.h Dave Jones
2005-11-10 22:20 ` Mike Krufky [this message]
2005-11-16  6:39   ` Dwaine Garden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4373C7B4.2000509@linuxtv.org \
    --to=mkrufky@linuxtv.org \
    --cc=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@brturbo.com.br \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox