* saa711x driver doesn't need segment.h
@ 2005-11-10 22:14 Dave Jones
2005-11-10 22:20 ` Mike Krufky
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jones @ 2005-11-10 22:14 UTC (permalink / raw)
To: Linux Kernel
This breaks compilation on non-x86 architectures,
and isn't even used.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.14/drivers/media/video/saa711x.c~ 2005-11-10 15:27:05.000000000 -0500
+++ linux-2.6.14/drivers/media/video/saa711x.c 2005-11-10 15:27:33.000000000 -0500
@@ -36,7 +36,6 @@
#include <asm/pgtable.h>
#include <asm/page.h>
#include <linux/sched.h>
-#include <asm/segment.h>
#include <linux/types.h>
#include <asm/uaccess.h>
#include <linux/videodev.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: saa711x driver doesn't need segment.h
2005-11-10 22:14 saa711x driver doesn't need segment.h Dave Jones
@ 2005-11-10 22:20 ` Mike Krufky
2005-11-16 6:39 ` Dwaine Garden
0 siblings, 1 reply; 3+ messages in thread
From: Mike Krufky @ 2005-11-10 22:20 UTC (permalink / raw)
To: Dave Jones
Cc: Linux Kernel, Mauro Carvalho Chehab, Andrew Morton,
Linux and Kernel Video
Dave Jones wrote:
>This breaks compilation on non-x86 architectures,
>and isn't even used.
>
>Signed-off-by: Dave Jones <davej@redhat.com>
>
>--- linux-2.6.14/drivers/media/video/saa711x.c~ 2005-11-10 15:27:05.000000000 -0500
>+++ linux-2.6.14/drivers/media/video/saa711x.c 2005-11-10 15:27:33.000000000 -0500
>@@ -36,7 +36,6 @@
> #include <asm/pgtable.h>
> #include <asm/page.h>
> #include <linux/sched.h>
>-#include <asm/segment.h>
> #include <linux/types.h>
> #include <asm/uaccess.h>
> #include <linux/videodev.h>
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
>
>
Acked-by: Michael Krufky <mkrufky@m1k.net>
Andrew-
Due to the above fix, please revert:
saa711x-is-busted-on-ppc64.patch
Thank you.
--
Michael Krufky
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: saa711x driver doesn't need segment.h
2005-11-10 22:20 ` Mike Krufky
@ 2005-11-16 6:39 ` Dwaine Garden
0 siblings, 0 replies; 3+ messages in thread
From: Dwaine Garden @ 2005-11-16 6:39 UTC (permalink / raw)
To: Linux and Kernel Video
Cc: Dave Jones, Andrew Morton, Mauro Carvalho Chehab, Linux Kernel
Mike Krufky wrote:
> Dave Jones wrote:
>
>> This breaks compilation on non-x86 architectures,
>> and isn't even used.
>>
>> Signed-off-by: Dave Jones <davej@redhat.com>
>>
>> --- linux-2.6.14/drivers/media/video/saa711x.c~ 2005-11-10
>> 15:27:05.000000000 -0500
>> +++ linux-2.6.14/drivers/media/video/saa711x.c 2005-11-10
>> 15:27:33.000000000 -0500
>> @@ -36,7 +36,6 @@
>> #include <asm/pgtable.h>
>> #include <asm/page.h>
>> #include <linux/sched.h>
>> -#include <asm/segment.h>
>> #include <linux/types.h>
>> #include <asm/uaccess.h>
>> #include <linux/videodev.h>
>> -
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>>
> Acked-by: Michael Krufky <mkrufky@m1k.net>
>
> Andrew-
>
> Due to the above fix, please revert:
>
> saa711x-is-busted-on-ppc64.patch
>
> Thank you.
>
Just tested out saa711x module with the USBVision driver and it works
perfectly. It's nice to have this module included with the v4l.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-11-16 6:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-10 22:14 saa711x driver doesn't need segment.h Dave Jones
2005-11-10 22:20 ` Mike Krufky
2005-11-16 6:39 ` Dwaine Garden
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox