* [PATCH 21/20] v4l: prevent saa7134 alsa undefined warnings
@ 2005-11-10 22:37 Mike Krufky
2005-11-11 13:49 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Mike Krufky @ 2005-11-10 22:37 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux and Kernel Video, linux-kernel, Mauro Carvalho Chehab
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Attachment #2: prevent-saa7134-alsa-undefined-warnings.patch --]
[-- Type: text/x-patch, Size: 1030 bytes --]
Prevent the following build warnings:
*** Warning: "snd_card_free"
*** Warning: "snd_card_register"
*** Warning: "snd_device_new"
*** Warning: "snd_card_new"
*** Warning: "snd_ctl_add"
*** Warning: "snd_ctl_new1"
*** Warning: "snd_pcm_set_ops"
*** Warning: "snd_pcm_new"
*** Warning: "snd_pcm_lib_ioctl"
*** Warning: "snd_pcm_hw_constraint_integer"
*** Warning: "snd_pcm_stop"
*** Warning: "snd_pcm_period_elapsed"
[drivers/media/video/saa7134/saa7134-alsa.ko] undefined!
Signed-off-by: Michael Krufky <mkrufky@m1k.net>
Acked-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
drivers/media/video/saa7134/Kconfig | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux.orig/drivers/media/video/saa7134/Kconfig
+++ linux/drivers/media/video/saa7134/Kconfig
@@ -1,6 +1,6 @@
config VIDEO_SAA7134
tristate "Philips SAA7134 support"
- depends on VIDEO_DEV && PCI && I2C && SOUND
+ depends on VIDEO_DEV && PCI && I2C && SOUND && SND && SND_PCM_OSS
select VIDEO_BUF
select VIDEO_IR
select VIDEO_TUNER
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 21/20] v4l: prevent saa7134 alsa undefined warnings
2005-11-10 22:37 [PATCH 21/20] v4l: prevent saa7134 alsa undefined warnings Mike Krufky
@ 2005-11-11 13:49 ` Takashi Iwai
2005-11-11 15:25 ` Michael Krufky
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2005-11-11 13:49 UTC (permalink / raw)
To: Mike Krufky
Cc: Andrew Morton, Linux and Kernel Video, linux-kernel,
Mauro Carvalho Chehab
At Thu, 10 Nov 2005 17:37:58 -0500,
Mike Krufky wrote:
>
> Prevent the following build warnings:
>
> *** Warning: "snd_card_free"
> *** Warning: "snd_card_register"
> *** Warning: "snd_device_new"
> *** Warning: "snd_card_new"
> *** Warning: "snd_ctl_add"
> *** Warning: "snd_ctl_new1"
> *** Warning: "snd_pcm_set_ops"
> *** Warning: "snd_pcm_new"
> *** Warning: "snd_pcm_lib_ioctl"
> *** Warning: "snd_pcm_hw_constraint_integer"
> *** Warning: "snd_pcm_stop"
> *** Warning: "snd_pcm_period_elapsed"
> [drivers/media/video/saa7134/saa7134-alsa.ko] undefined!
>
> Signed-off-by: Michael Krufky <mkrufky@m1k.net>
> Acked-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
>
> drivers/media/video/saa7134/Kconfig | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- linux.orig/drivers/media/video/saa7134/Kconfig
> +++ linux/drivers/media/video/saa7134/Kconfig
> @@ -1,6 +1,6 @@
> config VIDEO_SAA7134
> tristate "Philips SAA7134 support"
> - depends on VIDEO_DEV && PCI && I2C && SOUND
> + depends on VIDEO_DEV && PCI && I2C && SOUND && SND && SND_PCM_OSS
No, this driver should select SND_PCM_OSS, instead.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 21/20] v4l: prevent saa7134 alsa undefined warnings
2005-11-11 13:49 ` Takashi Iwai
@ 2005-11-11 15:25 ` Michael Krufky
0 siblings, 0 replies; 3+ messages in thread
From: Michael Krufky @ 2005-11-11 15:25 UTC (permalink / raw)
To: Takashi Iwai
Cc: Andrew Morton, Linux and Kernel Video, linux-kernel,
Mauro Carvalho Chehab
Takashi Iwai wrote:
> At Thu, 10 Nov 2005 17:37:58 -0500,
> Mike Krufky wrote:
>
>>Prevent the following build warnings:
>>
>>*** Warning: "snd_card_free"
>>*** Warning: "snd_card_register"
>>*** Warning: "snd_device_new"
>>*** Warning: "snd_card_new"
>>*** Warning: "snd_ctl_add"
>>*** Warning: "snd_ctl_new1"
>>*** Warning: "snd_pcm_set_ops"
>>*** Warning: "snd_pcm_new"
>>*** Warning: "snd_pcm_lib_ioctl"
>>*** Warning: "snd_pcm_hw_constraint_integer"
>>*** Warning: "snd_pcm_stop"
>>*** Warning: "snd_pcm_period_elapsed"
>>[drivers/media/video/saa7134/saa7134-alsa.ko] undefined!
>>
>>Signed-off-by: Michael Krufky <mkrufky@m1k.net>
>>Acked-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
>>
>> drivers/media/video/saa7134/Kconfig | 2 +-
>> 1 files changed, 1 insertion(+), 1 deletion(-)
>>
>>--- linux.orig/drivers/media/video/saa7134/Kconfig
>>+++ linux/drivers/media/video/saa7134/Kconfig
>>@@ -1,6 +1,6 @@
>> config VIDEO_SAA7134
>> tristate "Philips SAA7134 support"
>>- depends on VIDEO_DEV && PCI && I2C && SOUND
>>+ depends on VIDEO_DEV && PCI && I2C && SOUND && SND && SND_PCM_OSS
>
>
> No, this driver should select SND_PCM_OSS, instead.
>
>
> Takashi
Yes, I realized that after Andrew applied the patch. We will send a
correction in our next patchset.
-Michael Krufky
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-11-11 15:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-10 22:37 [PATCH 21/20] v4l: prevent saa7134 alsa undefined warnings Mike Krufky
2005-11-11 13:49 ` Takashi Iwai
2005-11-11 15:25 ` Michael Krufky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox