From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: rmk+kernel@armlinux.org.uk, airlied@linux.ie,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
xie.baoyou@zte.com.cn
Subject: Re: [PATCH] drm/armada: mark symbols static where possible
Date: Tue, 06 Sep 2016 15:44:13 +0200 [thread overview]
Message-ID: <4374246.7oBh2V74yj@wuerfel> (raw)
In-Reply-To: <1473147475-24639-1-git-send-email-baoyou.xie@linaro.org>
On Tuesday, September 6, 2016 3:37:55 PM CEST Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/armada/armada_gem.c:215:27: warning: no previous prototype for 'armada_gem_alloc_object' [-Wmissing-prototypes]
> drivers/gpu/drm/armada/armada_gem.c:423:1: warning: no previous prototype for 'armada_gem_prime_map_dma_buf' [-Wmissing-prototypes]
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> So this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2016-09-06 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 7:37 [PATCH] drm/armada: mark symbols static where possible Baoyou Xie
2016-09-06 13:44 ` Arnd Bergmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-10-22 9:03 Baoyou Xie
2016-11-01 20:13 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4374246.7oBh2V74yj@wuerfel \
--to=arnd@arndb.de \
--cc=airlied@linux.ie \
--cc=baoyou.xie@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox