From: Jeff Garzik <jgarzik@pobox.com>
To: mike.miller@hp.com
Cc: axboe@suse.de, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, steve.cameron@hp.com
Subject: Re: [PATCH 1/1] cciss: scsi error handling
Date: Fri, 11 Nov 2005 06:36:28 -0500 [thread overview]
Message-ID: <4374823C.1090704@pobox.com> (raw)
In-Reply-To: <20051104183037.GA8527@beardog.cca.cpqcorp.net>
mike.miller@hp.com wrote:
> PATCH 1 of 1
>
> This patch adds SCSI error handling code to the SCSI portion
> of the cciss driver.
>
> Signed-off-by: Stephen M. Cameron <steve.cameron@hp.com>
> Acked-by: Mike Miller <mike.miller@hp.com>
> +#ifdef CONFIG_CISS_SCSI_TAPE
Two comments:
1) CONFIG_CISS_SCSI_TAPE should be CONFIG_CCISS_SCSI_TAPE, IMO
2) is any locking needed in your scsi eh reset handlers? recent kernels
eliminate the lock that's been traditionally held around the handlers.
Jeff
next prev parent reply other threads:[~2005-11-11 11:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 18:30 [PATCH 1/1] cciss: scsi error handling mike.miller
2005-11-11 11:36 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-11-11 19:38 Cameron, Steve
2005-11-11 21:41 ` James Bottomley
2005-11-11 22:01 Cameron, Steve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4374823C.1090704@pobox.com \
--to=jgarzik@pobox.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mike.miller@hp.com \
--cc=steve.cameron@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox