From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
linux-kernel@vger.kernel.org,
"Antonino A. Daplas" <adaplas@pol.net>
Subject: Re: [PATCH] nvidiafb: Fix bug in nvidiafb_pan_display
Date: Sat, 12 Nov 2005 07:55:46 +0800 [thread overview]
Message-ID: <43752F82.1010004@gmail.com> (raw)
In-Reply-To: <1131752304.24637.260.camel@gaston>
Benjamin Herrenschmidt wrote:
> On Sat, 2005-11-12 at 07:28 +0800, Antonino A. Daplas wrote:
>> nvidiafb_pan_display() is incorrectly using the fields in
>> info->var instead of var passed to the function.
>
> Shouldn't it also update info->var is is this done by the core ?
>
Nobody calls or should call fbops->fb_pan_display() directly except
the wrapper fb_pan_display() in fbmem.c. It already does the checking
and the update to info->var. So checking and updating for the offsets
will be redundant.
Tony
next prev parent reply other threads:[~2005-11-11 23:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-11 4:35 2.6.14-mm2 Andrew Morton
2005-11-11 5:23 ` 2.6.14-mm2: loop detected in depmod Brice Goglin
2005-11-11 7:52 ` Antonino A. Daplas
2005-11-12 3:41 ` Brice Goglin
2005-11-11 5:49 ` 2.6.14-mm2 Reuben Farrelly
2005-11-11 6:07 ` 2.6.14-mm2 Andrew Morton
2005-11-11 8:28 ` 2.6.14-mm2 Reuben Farrelly
2005-11-11 8:55 ` 2.6.14-mm2 Andrew Morton
2005-11-11 13:28 ` 2.6.14-mm2 Reuben Farrelly
2005-11-11 8:54 ` 2.6.14-mm2 J.A. Magallon
2005-11-11 12:33 ` 2.6.14-mm2 Felipe Alfaro Solana
2005-11-11 16:40 ` [-mm patch] fs/ocfs2/file.c: make ocfs2_extend_allocation() static Adrian Bunk
2005-11-11 17:09 ` [-mm PATCH] slob: add kmem_set_shrinker Yoichi Yuasa
2005-11-11 19:14 ` 2.6.14-mm2 Badari Pulavarty
2005-11-11 19:21 ` 2.6.14-mm2 Andrew Morton
2005-11-11 19:32 ` 2.6.14-mm2 Badari Pulavarty
2005-11-11 22:32 ` 2.6.14-mm2 Michal Piotrowski
2005-11-11 22:37 ` 2.6.14-mm2 Michal Piotrowski
2005-11-11 23:01 ` 2.6.14-mm2 Andrew Morton
2005-11-11 23:28 ` [PATCH] nvidiafb: Fix bug in nvidiafb_pan_display Antonino A. Daplas
2005-11-11 23:38 ` Benjamin Herrenschmidt
2005-11-11 23:55 ` Antonino A. Daplas [this message]
2005-11-11 23:54 ` Michal Piotrowski
2005-11-11 23:30 ` 2.6.14-mm2 Michal Piotrowski
2005-11-12 0:45 ` 2.6.14-mm2 Antonino A. Daplas
2005-11-16 9:04 ` 2.6.14-mm2 KAMEZAWA Hiroyuki
2005-11-16 12:56 ` 2.6.14-mm2 KAMEZAWA Hiroyuki
2005-11-16 13:17 ` [Lhms-devel] 2.6.14-mm2 Dave Hansen
2005-11-16 16:02 ` Kamezawa Hiroyuki
2005-11-16 16:31 ` Dave Hansen
2005-11-16 16:39 ` Kamezawa Hiroyuki
2005-11-17 0:10 ` KAMEZAWA Hiroyuki
2005-11-17 9:16 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43752F82.1010004@gmail.com \
--to=adaplas@gmail.com \
--cc=adaplas@pol.net \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox