Re: [PATCH] Marvell SATA fixes v2

Bogdan Costescu
2005-11-24T20:32:09Z

On Wed, 23 Nov 2005, Jeff Garzik wrote:

> Bogdan Costescu wrote:
>> With MSI and libata DEBUG turned off I had a crash
>
> I wonder if the global reset disables MSI... may be a driver bug.

I'm sorry, but I don't follow you here: I have specified that MSI was
disabled, so why do you expect this to have any effect ? (I could have
made it clearer by adding a "both" before "turned off"...)

> You could play around with moving the pci_enable_msi until after the global
> reset...

I also don't follow:

pci_enable_msi() is only called from mv_init_one(); I think that the
global reset that you refer to is part of mv_init_host(), but this is
already called in mv_init_one() before pci_enable_msi().

Anyway, during all the speed testing, I was running the exact same
kernel that crashed - with more disks and more activity, and I
couldn't crash it anymore. Could you suggest, based on the stack dump,
how to make it more likely to crash again ?

--
Bogdan Costescu

IWR - Interdisziplinaeres Zentrum fuer Wissenschaftliches Rechnen
Universitaet Heidelberg, INF 368, D-69120 Heidelberg, GERMANY
Telephone: +49 6221 54 8869, Telefax: +49 6221 54 8868
E-mail: Bogdan.Costescu@IWR.Uni-Heidelberg.De