Re: X and intelfb fight over videomode

Antonino A. Daplas
2005-11-17T04:50:10Z

> On Thu, Nov 17, 2005 at 09:11:53AM +0800, Antonino A. Daplas wrote:
>> David Härdeman wrote:
>>> intelfb: Changing the video mode is not supported.
>
>
> Suggestions?

Ignore the hack I mentioned in the previous thread. Try this patch instead.

Tony

--- a/drivers/video/intelfb/intelfbdrv.c
+++ b/drivers/video/intelfb/intelfbdrv.c
@@ -1283,6 +1283,14 @@ intelfb_set_par(struct fb_info *info)

if (FIXED_MODE(dinfo)) {
ERR_MSG("Changing the video mode is not supported.\n");
+
+ /*
+ * We need to at least initialize the 2D engine even
+ * if changing the mode is not allowed
+ */
+ if (ACCEL(dinfo, info))
+ intelfbhw_2d_start(dinfo);
+
return -EINVAL;
}